Attention is currently required from: Bob Moragues, David Wu, Karthik Ramasubramanian, Kenneth Chan, Tyler Wang.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84193?usp=email )
Change subject: mb/google/brox/jubilant: Generate RAM IDs
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/84193/comment/1d81dd87_138540ee?usp... :
PS1, Line 10: MT62F1G32D2DS-023 WT:B 2 (0010)
: H58G56BK8BX068 2 (0010)
Do these two need to be de-conflicted?
The RAM ID is generated by tool.
The two memory types should share the same SPD parameters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84193?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b6e351ceaacfd65eae7b1db14c195b34359689a
Gerrit-Change-Number: 84193
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-CC: Bob Moragues
moragues@google.com
Gerrit-CC: Richard Lin
richardlin@quanta.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 03 Sep 2024 02:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bob Moragues
moragues@google.com