Change in coreboot[master]: soc/intel/common/block/xhci: Add API to disable USB devices - coreboot-gerrit

17 Jul 2019


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: soc/intel/common/block/xhci: Add API to disable USB devices
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33377/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/33377/5/src/soc/intel/common/block/... 
PS5, Line 52: false
...
I thought about it too. But wasn't sure to leave them enabled or disabled. […]
Yeah, I was just wondering. I am fine either ways. But, it feels safe to just let them be enabled? In either case, it would be good to add a comment here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied12faabee1b8c096f2b27de89ab42ee8be5d94d
Gerrit-Change-Number: 33377
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 16:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment