Attention is currently required from: Tim Wawrzynczak, Ravindra, Nick Vaccaro, Sridhar Siricilla, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60020 )
Change subject: soc/intel/common/cse: Update help text for CSE_OEMP_FILE ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60020/comment/a683feae_7cb54105 PS1, Line 10: Intel.The Please add a space after the dot/period.
Patchset:
PS1: How is `OEMP_FILE` used?
$ git grep OEMP_FILE src/soc/intel/common/block/cse/Kconfig:config CSE_OEMP_FILE
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/60020/comment/f35ea069_9e187110 PS1, Line 184: KM As the whole string is short enough, maybe use the longer form *Key Manifest*.
https://review.coreboot.org/c/coreboot/+/60020/comment/9b866ddd_1435eec2 PS1, Line 190: public private?
https://review.coreboot.org/c/coreboot/+/60020/comment/88bfb4c4_18c1bc07 PS1, Line 191: asset_generation/signing/outputs Is that a path? Maybe give an explicit example, what directory this file should live in.
https://review.coreboot.org/c/coreboot/+/60020/comment/9282e72e_8853c147 PS1, Line 190: to be : the part of No *the*? to be part of
-
Paul Menzel (Code Review)