Attention is currently required from: Martin L Roth, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held. Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64670 )
Change subject: mb/google/guybrush: Add better descriptors for USB endpoints ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/64670/comment/d3dd465d_4515efb5 PS2, Line 293: USB3
Again, this doesn't mean much to most users, and C1/A1 means absolutely nothing to anyone but us.
Hi Martin,
I am working to add custom `_PLD` (physical location of device) values for each USB port like this: https://review.coreboot.org/c/coreboot/+/64728/ As I was searching for the location of each specific port in the board layout, the desc pattern like `Left Type C port` was a bit confusing. For example, Skyrim previously had two `Left Type C port` so could not be distinguished which one is C0/C1: https://review.coreboot.org/c/coreboot/+/64530/ So, I was wondering if port desc in Guybrush and Skyrim could follow the desc pattern as in Brya boards. (USBX Type-C Port CX)
I think changing the desc to the actual port names like C0/A0 allows: 1. ports to be distinguished more clearly 2. future implementers of future boards to use similar desc pattern
Could this be a good reason to change the desc pattern?