Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family. ......................................................................
kukui: Introduce a new 'Jacuzzi' family.
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) so we want to create it as a special configuration inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M 3rdparty/blobs M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 3 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34344/1
diff --git a/3rdparty/blobs b/3rdparty/blobs index d7600dd..ca6cfcd 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d7600dd8718a076f0f9a89e53968b484254624dc +Subproject commit ca6cfcdbe1cdeb38c2622ee2e5236cc4657e3377 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 7719506..ba8e713 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -17,7 +17,10 @@ config BOARD_GOOGLE_KUKUI_COMMON def_bool n
-if BOARD_GOOGLE_KUKUI_COMMON +config BOARD_GOOGLE_JACUZZI_COMMON + def_bool n + +if BOARD_GOOGLE_KUKUI_COMMON || BOARD_GOOGLE_JACUZZI_COMMON
config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES @@ -48,6 +51,7 @@ default "Kukui" if BOARD_GOOGLE_KUKUI default "Krane" if BOARD_GOOGLE_KRANE default "Flapjack" if BOARD_GOOGLE_FLAPJACK + default "Jacuzzi" if BOARD_GOOGLE_JACUZZI
config DRIVER_TPM_SPI_BUS hex @@ -67,5 +71,5 @@ default "KUKUI TEST 9847" if BOARD_GOOGLE_KUKUI default "KRANE TEST 5417" if BOARD_GOOGLE_KRANE default "FLAPJACK TEST 4147" if BOARD_GOOGLE_FLAPJACK - + default "JACUZZI TEST 6792" if BOARD_GOOGLE_JACUZZI endif diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 348be66..65206a9 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -11,3 +11,7 @@ config BOARD_GOOGLE_FLAPJACK bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_JACUZZI + bool "-> Jacuzzi" + select BOARD_GOOGLE_JACUZZI_COMMON
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family. ......................................................................
Patch Set 1: Code-Review+1
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34344
to look at the new patch set (#2).
Change subject: kukui: Introduce a new 'Jacuzzi' family. ......................................................................
kukui: Introduce a new 'Jacuzzi' family.
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) so we want to create it as a special configuration inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34344/2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family. ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family. ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family. 1. Please remove the dot at the end of the commit message summary. 2. I think the common prefix is different for variants.
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@11 PS2, Line 11: special : configuration variant?
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34344
to look at the new patch set (#3).
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
kukui: Introduce a new 'Jacuzzi' family
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) so we want to create it as a special configuration inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34344/3
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
- Please remove the dot at the end of the commit message summary. […]
Can you elaborate more on what does that mean - common prefix different for variants?
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@11 PS2, Line 11: special : configuration
variant?
I'd prefer to not call it variant - the 'variant' has a special meaning in chromebooks referring as followers of a base board, while jacuzzi should be a new base board on its own.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 3:
(1 comment)
I'm a bit worried that the distinction between the kukui and jacuzzi baseboards may be too unclear.
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
Can you elaborate more on what does that mean - common prefix different for variants?
I don't understand what Paul means with the 2nd suggestion, but I'd change the "kukui:" at the beginning of the commit summary with "mb/kukui:".
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... PS3, Line 21: def_bool n The only purpose of this option is to guard the ones below, so you shouldn't create a new one for this. If you want to model differences between Kukui and Jacuzzi, you should create feature-specific Kconfigs for that inside the BOARD_GOOGLE_KUKUI_COMMON block. Take the GRU_HAS_xxx options in Gru as a template.
You could also make a KUKUI_BASEBOARD_JACUZZI analogous to GRU_BASEBOARD_SCARLET, however, you should only do this if there are really a lot of fundamental board layout differences on Jacuzzi (on Scarlet we did it because almost every I/O pin on the SoC changed) and you're planning to create a lot more variants that are modeled after Jacuzzi. It's sounds like you just have a handful of component changes here so I'd go with the per-feature Kconfigs, unless you'd need, say, more than 3 of them.
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34344
to look at the new patch set (#4).
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family. ......................................................................
mb/google/kukui: Introduce a new 'Jacuzzi' family.
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) and EC/keyboard so we want to create it as variants inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34344/4
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family. ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
I don't understand what Paul means with the 2nd suggestion, but I'd change the "kukui:" at the begin […]
Done
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... PS3, Line 21: def_bool n
The only purpose of this option is to guard the ones below, so you shouldn't create a new one for th […]
I'd imagine there'll be much more Jacuzzi's than Kukui, and that's why I created two different common groups.
But as you said, I may try building them with features.
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34344
to look at the new patch set (#5).
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family ......................................................................
mb/google/kukui: Introduce a new 'Jacuzzi' family
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) and EC/keyboard so we want to create it as variants inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34344/5
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
Done
Sorry I . forgot the dot. Updated.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 5: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7 PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
Sorry I . forgot the dot. Updated.
Done
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@11 PS2, Line 11: special : configuration
I'd prefer to not call it variant - the 'variant' has a special meaning in chromebooks referring as […]
Ack
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... PS3, Line 21: def_bool n
I'd imagine there'll be much more Jacuzzi's than Kukui, and that's why I created two different commo […]
Done
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family ......................................................................
mb/google/kukui: Introduce a new 'Jacuzzi' family
The 'Jacuzzi' is a different base board that will share most of Kukui design. For AP firmware, there will be only a few changes expected, mostly in display (for MIPI bridge) and EC/keyboard so we want to create it as variants inside Kukui folder, not forking a new directory.
BUG=b:137517228 TEST=make menuconfig; select 'krane' and build; select 'jacuzzi' and build.
Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753 Signed-off-by: Hung-Te Lin hungte@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34344 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index c32d3bf..fc86972 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -49,6 +49,7 @@ default "Krane" if BOARD_GOOGLE_KRANE default "Kodama" if BOARD_GOOGLE_KODAMA default "Flapjack" if BOARD_GOOGLE_FLAPJACK + default "Jacuzzi" if BOARD_GOOGLE_JACUZZI
config DRIVER_TPM_SPI_BUS hex @@ -69,5 +70,5 @@ default "KRANE TEST 5417" if BOARD_GOOGLE_KRANE default "KODAMA TEST 7122" if BOARD_GOOGLE_KODAMA default "FLAPJACK TEST 4147" if BOARD_GOOGLE_FLAPJACK - + default "JACUZZI TEST 6792" if BOARD_GOOGLE_JACUZZI endif diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 3fdd5b0..33049e3 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -15,3 +15,7 @@ config BOARD_GOOGLE_FLAPJACK bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_JACUZZI + bool "-> Jacuzzi" + select BOARD_GOOGLE_KUKUI_COMMON
-
Angel Pons (Code Review) -
Hung-Te Lin (Code Review)
-
Julius Werner (Code Review)
-
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
You-Cheng Syu (Code Review)
-
Yu-Ping Wu (Code Review)