Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32671
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
mb/google/sarien: Move EC PTS/WAK function to mainboard
Move optional EC PTS and WAK function into mainboard level.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie91a8168ae234f4fb4843c8587c77ae2f74aeb81 --- M src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl 2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32671/1
diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl index 7b252c7..c4a3842 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl @@ -26,3 +26,12 @@ _SB.PCI0.CTXS (CAM_EN) } } + +/* Method called from _PTS prior to enter sleep state */ +Method (MPTS, 1) { + _SB.PCI0.LPCB.EC0.PTS (Arg0) +} + +/* Method called from _WAK prior to wakeup */ +Method (MWAK, 1) { + _SB.PCI0.LPCB.EC0.WAK (Arg0) diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl index 7b252c7..c4a3842 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl @@ -26,3 +26,12 @@ _SB.PCI0.CTXS (CAM_EN) } } + +/* Method called from _PTS prior to enter sleep state */ +Method (MPTS, 1) { + _SB.PCI0.LPCB.EC0.PTS (Arg0) +} + +/* Method called from _WAK prior to wakeup */ +Method (MWAK, 1) { + _SB.PCI0.LPCB.EC0.WAK (Arg0)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32671
to look at the new patch set (#2).
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
mb/google/sarien: Move EC PTS/WAK function to mainboard
Move optional EC PTS and WAK function into mainboard level.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie91a8168ae234f4fb4843c8587c77ae2f74aeb81 --- M src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl 2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32671/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32671 )
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32671/2/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32671/2/src/mainboard/google/sarien/variants... PS2, Line 31: add a newline before { would make it consistent with the other methods
Hello Subrata Banik, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32671
to look at the new patch set (#3).
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
mb/google/sarien: Move EC PTS/WAK function to mainboard
Move optional EC PTS and WAK function into mainboard level.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie91a8168ae234f4fb4843c8587c77ae2f74aeb81 --- M src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl 2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32671/3
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32671 )
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32671/2/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32671/2/src/mainboard/google/sarien/variants... PS2, Line 31:
add a newline before { would make it consistent with the other methods
Done
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32671 )
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
Patch Set 3: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32671 )
Change subject: mb/google/sarien: Move EC PTS/WAK function to mainboard ......................................................................
mb/google/sarien: Move EC PTS/WAK function to mainboard
Move optional EC PTS and WAK function into mainboard level.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie91a8168ae234f4fb4843c8587c77ae2f74aeb81 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32671 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl 2 files changed, 24 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl index 7b252c7..bc03696 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl @@ -26,3 +26,15 @@ _SB.PCI0.CTXS (CAM_EN) } } + +/* Method called from _PTS prior to enter sleep state */ +Method (MPTS, 1) +{ + _SB.PCI0.LPCB.EC0.PTS (Arg0) +} + +/* Method called from _WAK prior to wakeup */ +Method (MWAK, 1) +{ + _SB.PCI0.LPCB.EC0.WAK (Arg0) +} diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl index 7b252c7..bc03696 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl @@ -26,3 +26,15 @@ _SB.PCI0.CTXS (CAM_EN) } } + +/* Method called from _PTS prior to enter sleep state */ +Method (MPTS, 1) +{ + _SB.PCI0.LPCB.EC0.PTS (Arg0) +} + +/* Method called from _WAK prior to wakeup */ +Method (MWAK, 1) +{ + _SB.PCI0.LPCB.EC0.WAK (Arg0) +}
-
Duncan Laurie (Code Review) -
Lijian Zhao (Code Review)