John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad ......................................................................
mb/google/volteer: Update settings for touchpad
Configure gpio settings for touchpad
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I525ba688f71b7a1893bcb64c77e02c8e2506d7b0 --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44524/1
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 09e8081..85f956a 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -44,6 +44,10 @@ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* B8 : ISH_I2C1_SCL ==> I2C_SENSOR_SCL */ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF1), + /* B9 : I2C5_SDA ==> PCH_I2C5_TRACKPAD_SDA */ + PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), + /* B10 : I2C5_SCL ==> PCH_I2C5_TRACKPAD_SCL */ + PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1),
/* C1 : SMBDATA ==> FPMCU_BOOT1 */ PAD_CFG_GPO(GPP_C1, 0, DEEP), @@ -87,6 +91,8 @@ PAD_NC(GPP_E12, NONE), /* E13 : SPI1_MOSI_IO0 ==> NC */ PAD_NC(GPP_E13, NONE), + /* E15 : ISH_GP6 ==> TRACKPAD_INT_ODL */ + PAD_CFG_GPI_IRQ_WAKE(GPP_E15, NONE, DEEP, LEVEL, INVERT), /* E16 : ISH_GP7 ==> SD_PRSNT# */ PAD_CFG_GPI(GPP_E16, NONE, DEEP), /* E17 : THC0_SPI1_INT# ==> NC */
Hello Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Angel Pons, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44524
to look at the new patch set (#2).
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
mb/google/volteer: Update settings for touchpad on Halvor
Configure gpio settings for touchpad.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I525ba688f71b7a1893bcb64c77e02c8e2506d7b0 --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44524/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
Patch Set 2: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
Patch Set 2: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
Patch Set 2:
Since baseboard only have NC pin, We need this for TP work.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... PS2, Line 61: PAD_NC(GPP_C13, NONE), is this your trackpad enable pin?
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for touchpad on Halvor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... PS2, Line 61: PAD_NC(GPP_C13, NONE),
is this your trackpad enable pin?
No, our trackpad enable pin is F12 (EN_PP3300_TRACKPAD).
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Angel Pons, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44524
to look at the new patch set (#3).
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
mb/google/volteer: Update settings for trackpad on Halvor
Configure gpio settings for trackpad.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I525ba688f71b7a1893bcb64c77e02c8e2506d7b0 --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44524/3
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/2/src/mainboard/google/voltee... PS2, Line 61: PAD_NC(GPP_C13, NONE),
No, our trackpad enable pin is F12 (EN_PP3300_TRACKPAD).
Ack
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... PS3, Line 112: GPP_F12 this pin is configured as a 1.8v GPIO in FIT. are you comfortable with that meeting the voltage threshold of the enable pin on the RT9742?
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... PS3, Line 112: GPP_F12
this pin is configured as a 1.8v GPIO in FIT. […]
I check this pin is configured as a 3.3v in FIT. And the halvor is using SYV616APAC load switch for trackepad, not use RT9742.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... PS3, Line 112: GPP_F12
I check this pin is configured as a 3.3v in FIT. […]
Ack
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee... PS3, Line 112: GPP_F12
Ack
ah, cool, i should have checked the halvor overrides :)
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor ......................................................................
mb/google/volteer: Update settings for trackpad on Halvor
Configure gpio settings for trackpad.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I525ba688f71b7a1893bcb64c77e02c8e2506d7b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44524 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Frank Wu: Looks good to me, but someone else must approve John Su: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 09e8081..85f956a 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -44,6 +44,10 @@ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* B8 : ISH_I2C1_SCL ==> I2C_SENSOR_SCL */ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF1), + /* B9 : I2C5_SDA ==> PCH_I2C5_TRACKPAD_SDA */ + PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), + /* B10 : I2C5_SCL ==> PCH_I2C5_TRACKPAD_SCL */ + PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1),
/* C1 : SMBDATA ==> FPMCU_BOOT1 */ PAD_CFG_GPO(GPP_C1, 0, DEEP), @@ -87,6 +91,8 @@ PAD_NC(GPP_E12, NONE), /* E13 : SPI1_MOSI_IO0 ==> NC */ PAD_NC(GPP_E13, NONE), + /* E15 : ISH_GP6 ==> TRACKPAD_INT_ODL */ + PAD_CFG_GPI_IRQ_WAKE(GPP_E15, NONE, DEEP, LEVEL, INVERT), /* E16 : ISH_GP7 ==> SD_PRSNT# */ PAD_CFG_GPI(GPP_E16, NONE, DEEP), /* E17 : THC0_SPI1_INT# ==> NC */
-
Caveh Jalali (Code Review) -
EricR Lai (Code Review)
-
Frank Wu (Code Review)
-
John Su (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)