Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config ......................................................................
Patch Set 12:
(3 comments)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68472/comment/48bbbc53_653f8d77 PS7, Line 8: Set STAPM confiuration
STAPM is different from DPTC. These comments should indicate these are for DPTC.
Done
https://review.coreboot.org/c/coreboot/+/68472/comment/e51a1c86_c269a306 PS7, Line 23: # Set STAPM confiuration. Table C : register "thermctl_limit_degreeC_C" = "97" : register "fast_ppt_limit_mW_C" = "30000" : register "slow_ppt_limit_mW_C" = "15000" : register "slow_ppt_time_constant_s_C" = "5" : register "sustained_power_limit_mW_C" = "15000"
Remove, since it matches table A.
Done
https://review.coreboot.org/c/coreboot/+/68472/comment/c3b781d0_e8b758d1 PS7, Line 30: # Set STAPM confiuration. Table D : register "thermctl_limit_degreeC_D" = "97" : register "fast_ppt_limit_mW_D" = "30000" : register "slow_ppt_limit_mW_D" = "10000" : register "slow_ppt_time_constant_s_D" = "5" : register "sustained_power_limit_mW_D" = "10000"
Remove, since it matches table B.
Done