Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Lean Sheng Tan, Nill Ge, Patrick Rudolph, TangYiwei, niehaitao@bytedance.com.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75722/comment/d964f6ab_52217e60 : PS3, Line 4: TangYiwei Please add a space, and put the surname at the end. (I think this is from the Gerrit configuration/profile.)
https://review.coreboot.org/c/coreboot/+/75722/comment/888e08bb_52eba8c9 : PS3, Line 11: Please look at commit 30e743e7cc7f (mb/ibm: Add 4 SPR sockets server board IBM SBP1), Ie21c744224e8d9e5232d63b8366d2981c9575d70 1 how to add a new board, and how to write the commit message.
https://review.coreboot.org/c/coreboot/+/75722/comment/560cda75_bcf4abf8 : PS3, Line 14: Yuuka_Kazami caolong01@inspur.com : Co-authored-by: wanghao11 wanghao11@inspur.com : Co-authored-by: lanchenyu lanchenyu@inspur.com : Co-authored-by: laykong lay.kong@intel.com : Co-authored-by: kehong-intel kehong.chen@intel.com : Co-authored-by: ziang ziang.wang@intel.com : Co-authored-by: weidong weidong.wd@bytedance.com : Co-authored-by: lichenchen.carl It’d be great if you spelled the full names as the other names.
Patchset:
PS3: Welcome to coreboot and thank you very much for the contribution.