Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85566?usp=email )
Change subject: mb/google/nissa/var/rull: For probe, change unprovisioned to unknown
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think you still need fw_config_is_provisioned for SMT? or your factory will always pre-flash FW co […]
The FW branch(15217) of nissa is relatively old,, and the method of not updating fw_config (probe unprovisioned) is not supported, so fw_config will still be updated first, but the Bluetooth of WIFI6E will not be usable. It is currently used in the fw branch (skipping upstream).https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Due to the existence of ```assert```, we can't directly use ```fw_config_probe(FW_CONFIG(WIFI, WIFI_UNKNOWN))```, otherwise it will fail to boot. However, since the BT function is ignored, it is better to continue using the ```WIFI_UNKNOWN``` method from the source.
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85566?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2415d18c635dece94500f511bccdc9d2b69d1b4
Gerrit-Change-Number: 85566
Gerrit-PatchSet: 3
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 13 Dec 2024 02:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com