Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 )
Change subject: amdfwtool: Add support for AMD's BIOS A/B recovery feature ......................................................................
Patch Set 47:
(5 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/56773/comment/90741342_e3444983 PS46, Line 234: AMD_FW_PSP_TRUSTLETKEY
not sure is this is needed in the PSP_LVL2_AB case; if so, please add. […]
AMD_FW_PSP_RECOVERY: not for A/B reocvery for sure. AMD_FW_PSP_RTM_PUBKEY: not sure if A/B recovery need it.
https://review.coreboot.org/c/coreboot/+/56773/comment/fe78aff4_cb2f5d36 PS46, Line 236: AMD_FW_PSP_SMU_FIRMWARE
all AMD_FW_PSP_SMU_FIRMWARE(2), AMD_SEC_GASKET and AMD_MP2_FW entries should likely be marked as PSP […]
Done
https://review.coreboot.org/c/coreboot/+/56773/comment/d149c5e6_bc35311d PS46, Line 1755:
when recovery_ab is set, i'd verify if multi_level is also set and possibly return an error with som […]
Done if (cb_config.recovery_ab) { cb_config.multi_level = true; }
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/56773/comment/4fe06a38_79fc9fcd PS46, Line 118: == 1
since cb_config->recovery_ab is a boolean, the == 1 should probably be dropped here
Done
https://review.coreboot.org/c/coreboot/+/56773/comment/6a8476ac_57d92154 PS46, Line 125: cb_config->recovery_ab == 0
!cb_config->recovery_ab
Done
-
Bao Zheng (Code Review)