Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 adc init
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85734/comment/14acc74d_23eac403?usp... :
PS3, Line 7: adc
Actually configs MT6685 ADC SW initial setting here, TIA will read thermal info in HW.
Please mention this in the commit message. If the initial setting includes other features, please also mention them in the commit message.
File src/soc/mediatek/common/mt6685.c:
https://review.coreboot.org/c/coreboot/+/85734/comment/10eb0df7_d945e34d?usp... :
PS3, Line 59: wdata = mt6685_read_field(MT6685_TOP_RST_MISC, 0xFFFF, 0);
: printk(BIOS_INFO, "[%s]MT6685 TOP_RST_MISC = %#x\n", __func__, wdata);
Done
done what ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85734?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e
Gerrit-Change-Number: 85734
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 24 Dec 2024 14:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com