Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60401/comment/b62c97f2_24cb72aa PS4, Line 13: pop up
`shows`
Done
https://review.coreboot.org/c/coreboot/+/60401/comment/cd5af1f3_71c9b751 PS4, Line 13: add
`adds`
Done
Patchset:
PS4:
Not very sure about the usefulness of this code, but looks good to me. […]
thanks, i actually have a project have duplicated clkreq assignment and it really have to enable fsp log to find out the duplication.
Sometimes it's hard to observe duplication btwn baseboard dev tree and override dev tree since they are in different file.
Patchset:
PS5: thanks Tim and Subrata.
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/2fee94eb_f5c51582 PS4, Line 55: uint16_t
You say a 32-bit mapping in the comment above but this is a uint16_t. […]
Done
-
Kane Chen (Code Review)