Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )
Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock ......................................................................
Patch Set 13:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84025/comment/3dee8c52_c40cdb06?usp... : PS8, Line 7: add
Add
Done
File src/soc/mediatek/mt8196/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/2b2a275e_46016d9c?usp... : PS7, Line 6: #include <soc/eint_event.h>
sort
Done
File src/soc/mediatek/mt8196/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/40b1046d_fbca0ea4?usp... : PS7, Line 2: #include <soc/addressmap.h> : #include <console/console.h> : #include <soc/eint_event.h>
sort
Done
https://review.coreboot.org/c/coreboot/+/84025/comment/a56eb130_785d5133?usp... : PS7, Line 6: void
static void
Done
https://review.coreboot.org/c/coreboot/+/84025/comment/d8e8ff4f_b972e7f6?usp... : PS7, Line 11: *(unsigned int *)(base + EVENT_MASK_CLEAN + i * NEXT_ADDRESS) = MASK_VALUE;
write32p
Done
https://review.coreboot.org/c/coreboot/+/84025/comment/d6f0ecf3_a3c3b976?usp... : PS7, Line 13: dsb();
no need.
Done
File src/soc/mediatek/mt8196/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/ea34bfd0_b8aba68c?usp... : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
One blank line below.
Done
File src/soc/mediatek/mt8196/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/84025/comment/6bb17d29_db73991a?usp... : PS8, Line 13:
tabs
Done
File src/soc/mediatek/mt8196/include/soc/eint_event.h:
https://review.coreboot.org/c/coreboot/+/84025/comment/d3d389cf_eca80506?usp... : PS8, Line 16: unmask eint event, eint can wakeup by spm
`Unmask eint event, which can be woken up by SPM. […]
Move to common/include/soc/eint_event.h
File src/soc/mediatek/mt8196/include/soc/eint_event.h:
PS7:
just use `soc/eint_event. […]
Done and move "struct eint_event_reg" to eint_event.c.
https://review.coreboot.org/c/coreboot/+/84025/comment/ae5b28fc_63dbe7bc?usp... : PS7, Line 7: #define EVENT_MASK_CLEAN 0x880 : #define NEXT_ADDRESS 4 : #define MASK_VALUE 0xFFFFFFFF : #define MAX_E 3 : #define MAX_S 2 : #define MAX_W 2 : #define MAX_N 2 : #define MAX_C 1
move to `eint_event. […]
Done