[M] Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA
Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Tim Van Patten, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74334 )
Change subject: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA ......................................................................
Patch Set 4:
(2 comments)
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/74334/comment/627b9bdd_00491cbc PS4, Line 54: can_use_dma
Have you checked if all the new targets we are reading are 64byte aligned?
Atleast the source and dest are 64 byte aligned and the size is > 64 bytes. Copied the log snippet capturing all the files being read.
[INFO ] CBFS: Found 'fspm.bin' @0x63c40 size 0x24433 in mcache @0x020250c0 [SPEW ] spi_dma_readat_dma: start: dest: 0x02181600, source: 0x83cc0, size: 148531 -- [INFO ] CBFS: Found 'fallback/ramstage' @0x30300 size 0x2f2d7 in mcache @0x02024fc0 [SPEW ] spi_dma_readat_dma: start: dest: 0x02181600, source: 0x50380, size: 193239 -- [DEBUG] FMAP: area RO_VPD found @ 800000 (16384 bytes) [SPEW ] spi_dma_readat_dma: start: dest: 0x02181600, source: 0x800000, size: 16384 -- [INFO ] CBFS: Found 'fsps.bin' @0x88100 size 0xb357 in mcache @0xb877c300 [SPEW ] spi_dma_readat_dma: start: dest: 0x02187600, source: 0xa8180, size: 45911 -- [INFO ] CBFS: Found 'pci1002,1506.rom' @0x93500 size 0xae00 in mcache @0xb877c380 [SPEW ] spi_dma_readat_dma: start: dest: 0x02187600, source: 0xb3580, size: 44544 -- [INFO ] CBFS: Found 'cpu_microcode_8a00.bin' @0x9e380 size 0xc80 in mcache @0xb877c400 [SPEW ] spi_dma_readat_dma: start: dest: 0x02192400, source: 0xbe400, size: 3200 -- [INFO ] CBFS: Found 'fallback/dsdt.aml' @0x5f680 size 0x4527 in mcache @0xb877c200 [SPEW ] spi_dma_readat_dma: start: dest: 0x02193080, source: 0x7f700, size: 17703 -- [INFO ] Couldn't obtain OEM name from CBI [SPEW ] spi_dma_readat_dma: start: dest: 0x021975c0, source: 0x61e000, size: 4096 -- [INFO ] CBFS: Found 'fallback/payload' @0xc4a80 size 0x2811c in mcache @0xb877c6d8 [SPEW ] spi_dma_readat_dma: start: dest: 0x021985c0, source: 0xe4b00, size: 164124
File src/soc/amd/mendocino/Kconfig:
https://review.coreboot.org/c/coreboot/+/74334/comment/5c2c5097_2a1c01dc PS4, Line 246: SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA
We should back port this to guybrush and skyrim :)
Ack. On Guybrush, for some reason memory mapped access is better than in skyrim. I am not sure why that is the case. But definitely will backport to both guybrush and skyrim.
-
Karthik Ramasubramanian (Code Review)