Change in coreboot[master]: mb/google/dedede Add Audio support for waddledoo

[Varshit B Pandya (Code Review)]

Hello Usha P,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39322

to review the following change.

Change subject: mb/google/dedede Add Audio support for waddledoo
......................................................................

mb/google/dedede Add Audio support for waddledoo

1. Configure Audio GPIOs.
2. Set i2c4 configuration.

Signed-off-by: Pandya, Varshit B 
Signed-off-by: Yong Zhi 
Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9

Signed-off-by: Usha P 
Change-Id: Ic3dc7e199a74ff5335ce3e9f490629a01438d576
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
3 files changed, 66 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/39322/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig
index ebca580..cfb8813 100644
--- a/src/mainboard/google/dedede/Kconfig
+++ b/src/mainboard/google/dedede/Kconfig
@@ -1,5 +1,7 @@
 config BOARD_GOOGLE_BASEBOARD_DEDEDE
    def_bool n
+	select DRIVERS_GENERIC_MAX98357A
+	select DRIVERS_I2C_DA7219
    select DRIVERS_I2C_GENERIC
    select DRIVERS_I2C_HID
    select DRIVERS_SPI_ACPI
@@ -14,7 +16,6 @@
    select MAINBOARD_HAS_SPI_TPM_CR50
    select MAINBOARD_HAS_TPM2
    select SOC_INTEL_JASPERLAKE
-
 if BOARD_GOOGLE_BASEBOARD_DEDEDE

config BASEBOARD_DEDEDE_LAPTOP
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index 8049040..1e5f859 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -13,6 +13,19 @@

/* Pad configuration in ramstage*/
 static const struct pad_config gpio_table[] = {
+	/* R0  : I2S_HP_BCLK */
+	PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2),
+	/* R1  : I2S_HP_LRCK */
+	PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2),
+	/* R2  : I2S_HP_AUDIO */
+	PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2),
+	/* R3  : I2S_HP_MIC */
+	PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2),
+	/* R6  : I2S_SPK_LRCK */
+	PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1),
+	/* R7  :  I2S_SPK_AUDIO */
+	PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1),
+
    /* GPP_A0 thru GPP_A6 come configured out of reset, do not touch */
    /* A0  : ESPI_IO0 */
    /* A1  : ESPI_IO1 */
@@ -47,6 +60,15 @@
    /* B23 : EC_AP_USB_C1_HDMI_HPD */
    PAD_CFG_NF(GPP_B23, NONE, DEEP, NF1),

+	/* S2  : DMIC_CLK_1 */
+	PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2),
+	/* S3  : DMIC_DATA_1 */
+	PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2),
+	/* S6  :  DMIC_CLK_0 */
+	PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2),
+	/* S7  : DMIC_DATA_0 */
+	PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2),
+
    /* C0  : RAM_STRAP_0 */
    PAD_CFG_GPI(GPP_C0, NONE, DEEP),
    /* C3  : RAM_STRAP_1 */
@@ -72,6 +94,13 @@
    /* C23 : UART2_CTS_N */
    PAD_NC(GPP_C23, DN_20K),

+	/* D16  : HP_INT_ODL*/
+	PAD_CFG_GPI_INT(GPP_D16, NONE, PLTRST, EDGE_BOTH),
+	/* D17  : EN_SPK */
+	PAD_CFG_GPO(GPP_D17, 1, PLTRST),
+	/* D18  : I2S_MCLK */
+	PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1),
+
    /* F7  : EMMC_CMD */
    PAD_CFG_NF(GPP_F7, NONE, DEEP, NF1),
    /* F8  : EMMC_DATA0 */
@@ -126,6 +155,8 @@
    PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1),
    /* H9  : AP_I2C_AUDIO_SCL */
    PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1),
+	/* H15  :  I2S_SPK_BCLK */
+	PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1),
 };

/* Early pad configuration in bootblock */
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index 061a0f8..87dd187 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -36,6 +36,12 @@
    	},
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 176,
+				.scl_hcnt = 95,
+				.sda_hold = 36,
+			}
    	},
    }"
    device domain 0 on
@@ -49,5 +55,32 @@
    			device i2c 15 on end
    		end
    	end #I2C 0
+		device pci 19.0 on
+			chip drivers/i2c/da7219
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)"
+				register "btn_cfg" = "50"
+				register "mic_det_thr" = "500"
+				register "jack_ins_deb" = "20"
+				register "jack_det_rate" = ""32ms_64ms""
+				register "jack_rem_deb" = "1"
+				register "a_d_btn_thr" = "0xa"
+				register "d_b_btn_thr" = "0x16"
+				register "b_c_btn_thr" = "0x21"
+				register "c_mic_btn_thr" = "0x3e"
+				register "btn_avg" = "4"
+				register "adc_1bit_rpt" = "1"
+				register "micbias_lvl" = "2600"
+				register "mic_amp_in_sel" = ""diff""
+				device i2c 1a on end
+			end
+		end #I2C 4
+                device pci 1f.3 on
+                        chip drivers/generic/max98357a
+                                register "hid" = ""MX98360A""
+				register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)"
+                                device generic 0 on end
+                        end
+                end # Intel HDA
+
    end
 end

[Varshit B Pandya (Code Review)]

Varshit B Pandya has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39322 )

Change subject: mb/google/dedede Add Audio support for waddledoo
......................................................................

Abandoned