Change in ...coreboot[master]: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proo...

[John Looney (Code Review)]

John Looney has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32087


Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................

Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept

Signed-off-by: John Looney <[e-mail]>
Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
---
A src/mainboard/emulation/qemu-q35/board.fmd
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/1

diff --git a/src/mainboard/emulation/qemu-q35/board.fmd b/src/mainboard/emulation/qemu-q35/board.fmd
new file mode 100644
index 0000000..a97e218
--- /dev/null
+++ b/src/mainboard/emulation/qemu-q35/board.fmd
@@ -0,0 +1,16 @@
+# layout for firmware residing at top of 4GB address space
+# +-------------+ <-- 4GB - ROM_SIZE / start of flash
+# | unspecified |
+# +-------------+ <-- 4GB - BIOS_SIZE
+# | FMAP |
+# +-------------+ <-- 4GB - BIOS_SIZE + FMAP_SIZE
+# | CBFS |
+# +-------------+ <-- 4GB / end of flash
+FLASH@4278190080 0x1000000 {
+ BIOS@0 0x1000000 {
+  FMAP@0 0x200
+  RO_VPD@0x200 0x10000
+  RW_VPD@0x10200 0x1000
+  COREBOOT(CBFS)@0x11200
+ }
+}

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 1
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-MessageType: newchange

[John Looney (Code Review)]

John Looney has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................

Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept

Signed-off-by: John Looney <[e-mail]>
Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
---
M src/arch/x86/acpi.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-q35/Kconfig
A src/mainboard/emulation/qemu-q35/board.fmd
4 files changed, 36 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 2
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-MessageType: newpatchset

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32087/2/src/mainboard/emulation/qemu-i440fx/... 
File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:

https://review.coreboot.org/#/c/32087/2/src/mainboard/emulation/qemu-i440fx/... 
PS2, Line 257: 				printk(BIOS_DEBUG, "Found RSDP at 0x%lx\n", current);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 2
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 27 Mar 2019 22:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[John Looney (Code Review)]

John Looney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................


Patch Set 2:

Hey, take a peek when you have a minute :)


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 2
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 28 Mar 2019 13:44:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/32087/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32087/2//COMMIT_MSG@8 
PS2, Line 8: 
Please follow the gerrit guidelines and add a short topic. In the commit body explain why it's useful and how it was tested.

Please split the commit into two: one for SSDT and one for FMAP.
Please update qemu-i440fx as well.


https://review.coreboot.org/#/c/32087/2/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/32087/2/src/arch/x86/acpi.c@a41 
PS2, Line 41: 
unrelated



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 2
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Sun, 31 Mar 2019 08:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[John Looney (Code Review)]

John Looney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept
......................................................................


Patch Set 2:

fmd changes moved out to https://review.coreboot.org/c/coreboot/+/32144

acpi.c change removed


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 2
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 02 Apr 2019 19:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[John Looney (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/32087

to look at the new patch set (#3).

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus     qemu-q35 also.
......................................................................

Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus
    qemu-q35 also.

    This will allow qemu to setup cbmem, and allow VPD variables to be accessible
    from operating systems booted by qemu.

    This has been tested by booting a qemu-q35 instance from a coreboot image with
    a VPD partition defined in the fmap. On booting, /sys/firmware/vpd/ro existed
    as it does on real hardware.

    A subsequent commit will contain default fmaps for qemu images, which will
    include small VPD partitions.

Signed-off-by: John Looney <[e-mail]>
Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
---
M src/arch/x86/acpi.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-q35/Kconfig
A src/mainboard/emulation/qemu-q35/board.fmd
4 files changed, 36 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 3
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[John Looney (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/32087

to look at the new patch set (#4).

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................

Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.

This will allow qemu to setup cbmem, and allow VPD variables to be accessible from operating systems booted by qemu.

This has been tested by booting a qemu-q35 instance from a coreboot image with a VPD partition defined in the fmap. On booting, /sys/firmware/vpd/ro existed as it does on real hardware.

A subsequent commit will contain default fmaps for qemu images, which will include small VPD partitions.

Signed-off-by: John Looney <[e-mail]>
Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
---
M src/arch/x86/acpi.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-q35/Kconfig
A src/mainboard/emulation/qemu-q35/board.fmd
4 files changed, 36 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 4
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[John Looney (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/32087

to look at the new patch set (#5).

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................

Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus
qemu-q35 also.

This will allow qemu to setup cbmem, and allow VPD variables to be accessible
from operating systems booted by qemu.

This has been tested by booting a qemu-q35 instance from a coreboot image with
a VPD partition defined in the fmap. On booting, /sys/firmware/vpd/ro existed
as it does on real hardware.

A subsequent commit will contain default fmaps for qemu images, which will
include small VPD partitions.

Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
---
M src/mainboard/emulation/qemu-i440fx/Kconfig
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-q35/Kconfig
3 files changed, 39 insertions(+), 15 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 5
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/32087/5/src/mainboard/emulation/qemu-i440fx/... 
File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:

https://review.coreboot.org/#/c/32087/5/src/mainboard/emulation/qemu-i440fx/... 
PS5, Line 257: 				printk(BIOS_DEBUG, "Found RSDP at 0x%lx\n", current);
line over 80 characters


https://review.coreboot.org/#/c/32087/5/src/mainboard/emulation/qemu-i440fx/... 
PS5, Line 380: 		if (entry.headertype == SMBIOS_FIELD_ENTRY && entry.tabletype == 1) {
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 5
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 02 Apr 2019 19:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32087/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32087/2//COMMIT_MSG@8 
PS2, Line 8:
> Please follow the gerrit guidelines and add a short topic. […]
> Which guidelines? Maybe we need to add something (e.g. a pointer to a useful guide) about commit message style here: 
> https://doc.coreboot.org/lessons/lesson2.html

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32087/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32087/5//COMMIT_MSG@21 
PS5, Line 21: 
Needs a signed-off-by line.
https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 5
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: David Hendricks <[e-mail]>
Gerrit-CC: Martin Roth <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Wed, 03 Apr 2019 02:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[John Looney (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/32087

to look at the new patch set (#6).

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................

Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus
qemu-q35 also.

This will allow qemu to setup cbmem, and allow VPD variables to be accessible
from operating systems booted by qemu.

This has been tested by booting a qemu-q35 instance from a coreboot image with
a VPD partition defined in the fmap. On booting, /sys/firmware/vpd/ro existed
as it does on real hardware.

A subsequent commit will contain default fmaps for qemu images, which will
include small VPD partitions.

Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Signed-off-by: John Looney <[e-mail]>
---
M src/mainboard/emulation/qemu-i440fx/Kconfig
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-q35/Kconfig
3 files changed, 39 insertions(+), 15 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32087/6
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 6
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: David Hendricks <[e-mail]>
Gerrit-CC: Martin Roth <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................


Patch Set 6:

(3 comments)

https://review.coreboot.org/#/c/32087/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32087/6//COMMIT_MSG@10 
PS6, Line 10: This will allow qemu to setup cbmem, and allow VPD variables to be accessible
how does ssdt and cbmem affect VPD?


https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-i440fx/... 
File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:

https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-i440fx/... 
PS6, Line 25: 
please no unrelated changes


https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-q35/Kco... 
File src/mainboard/emulation/qemu-q35/Kconfig:

https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-q35/Kco... 
PS6, Line 57: config FMDFILE
should be part of the commit introducing the fmap



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 6
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: David Hendricks <[e-mail]>
Gerrit-CC: Martin Roth <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Wed, 03 Apr 2019 06:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in coreboot[master]: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, ...

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32087?usp=email )

Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................


Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32087?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 6
Gerrit-Owner: John Looney <[e-mail]>
Gerrit-Reviewer: John Looney <[e-mail]>
Gerrit-Reviewer: Philipp Deppenwiese <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: David Hendricks <[e-mail]>
Gerrit-CC: Martin L Roth <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon