[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 adc init

[Hope Wang (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.

Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )

Change subject: soc/mediatek/mt8196: Add MT6685 adc init
......................................................................

Patch Set 4:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85734/comment/7fed76f0_8ce626a7?usp... :
PS3, Line 7: adc
> We don't use ADC function on MT6685 and this patch does not implement ADC function, too.

Actually configs MT6685 ADC SW initial setting here, TIA will read thermal info in HW.

File src/soc/mediatek/common/mt6685.c:

https://review.coreboot.org/c/coreboot/+/85734/comment/493f4ad5_962edf08?usp... :
PS3, Line 10: define MT6685_SLAVE_ID			0x9
> remove

Done

https://review.coreboot.org/c/coreboot/+/85734/comment/0be4ddba_95f90afe?usp... :
PS3, Line 31: MT6685_SLAVE_ID
> SPMI_SLAVE_9

Done

https://review.coreboot.org/c/coreboot/+/85734/comment/c9b67f7d_3884d4bb?usp... :
PS3, Line 59: 	wdata = mt6685_read_field(MT6685_TOP_RST_MISC, 0xFFFF, 0);
            : 	printk(BIOS_INFO, "[%s]MT6685 TOP_RST_MISC = %#x\n", __func__, wdata);
> Why do we need to print the register content before setting ?

Done

https://review.coreboot.org/c/coreboot/+/85734/comment/744b1708_ee00689e?usp... :
PS3, Line 81: "[mt6685]CHIP ID = %#x\n", mt6685_read_field(0xb, 0xFF, 0)
> "[%s][MT6685]CHIP ID = %#x\n", __func__, mt6685_read_field(0xb, 0xFF, 0)

Done