Vlado Cibic has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33328
Change subject: src/mainboards/asus: Add support for P8Z77-M PRO mainboard ......................................................................
src/mainboards/asus: Add support for P8Z77-M PRO mainboard
Add support for ASUS P8Z77-M PRO mainboard Signed-off-by: Vlado Ciric vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,551 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/1
diff --git a/Documentation/mainboard/asus/p8z77-m_pro.jpg b/Documentation/mainboard/asus/p8z77-m_pro.jpg new file mode 100644 index 0000000..5c6411e --- /dev/null +++ b/Documentation/mainboard/asus/p8z77-m_pro.jpg Binary files differ diff --git a/Documentation/mainboard/asus/p8z77-m_pro.md b/Documentation/mainboard/asus/p8z77-m_pro.md new file mode 100644 index 0000000..b7c69ca --- /dev/null +++ b/Documentation/mainboard/asus/p8z77-m_pro.md @@ -0,0 +1,169 @@ +# ASUS P8Z77-M Pro + +This page describes how to run coreboot on the [ASUS P8Z77-M Pro] + +## Flashing coreboot + +```eval_rst ++---------------------+----------------+ +| Type | Value | ++=====================+================+ +| Socketed flash | yes | ++---------------------+----------------+ +| Model | W25Q64FVA1Q | ++---------------------+----------------+ +| Size | 8 MiB | ++---------------------+----------------+ +| Package | DIP-8 | ++---------------------+----------------+ +| Write protection | yes | ++---------------------+----------------+ +| Dual BIOS feature | no | ++---------------------+----------------+ +| Internal flashing | yes | ++---------------------+----------------+ +``` + +The flash IC is located right next to one of the SATA ports: +![](p8z77-m_pro.jpg) + +### Internal programming + +The main SPI flash cannot be written because Asus disables BIOSWE and +enables BLE/SMM_BWP flags in BIOS_CNTL for their latest bioses. +An external programmer is required. + +## Known issues + +- The rear's USB3s on bottom (closest to the PCB) have problems booting or + being used before the OS loads. For better compatibility, please use + the Z77's ones above the Ethernet connector or the Asmedia's top one. + +- After S3 suspend, some USB3 connectors on rear seem not to work. + +- At the moment, the power led does not blink when entering S3 state. + +- Although you can set gfx_uma_size NVRAM variable to 1024M, seems the + maximum real allocable memory in Mint 19.1 is 544Mb. Using MRC.bin, + seems the maximum allocable real size is 32Mb, independently of + the value of gfx_uma_size. The original Asus 2203 bios is 544Mb too. + +- Currently, we have not setup the SuperIO's Hardware Monitor (HWM), + so only the CPU sensors are reported. + +- Using TianoCore + a PCIe GPU, Windows crashes with a ACPI_BIOS_ERROR + fatal code, not sure why. Using just the IGP alone is ok and works + perfectly. + +- Under Windows 10, if you experiment problems with PS/2 devices, change + HKLM\SYSTEM\CurrentControlSet\Services\i8042prt->Start from '3' to '1' + Anyways, PS2 keyboard/mouse seems not to work! + +## Untested + +- EHCI & COM debugging +- S/PDIF audio +- Wake-on-LAN +- Serial port + +## Not working + +- PS/2 keyboard in Win10 using tianocore (please see [Known issues]) +- PS/2 mouse using tianocore +- PCIe graphics card on Windows & tianocore (throws critical ACPI_BIOS_ERROR) + +## Working + +- PS/2 keyboard with SEABios & tianocore (in Mint 18.3/19.1) + +- Rear/front headphones connector audio & mic + +- S3 Suspend to RAM (tested with OS installed in a HDD/SSD and also with a + Mint 19.1 LiveUSB pendrive on USB3 and USB2 connectors), but please see + [Known issues] + +- USB2 on rear + +- USB3 (Z77's and Asmedia's works, but please see [Known issues]) + +- Gigabit Ethernet (RTL8111F) + +- SATA3, SATA2 and eSATA on all ports ! + +- NVME SSD boot on PCIe-x16/x8/4x slot (tested with M.2-to-PCIe adapter and + a M.2 Samsung EVO 970 SSD). + +- CPU Temp sensors (tested PSensor on linux + HWINFO64 on Windows) + +- TPM on TPM-header (tested tpm-tools with Asus TPM 1.2 Infineon SLB9635TT12) + +- Native raminit and also MRC.bin(systemagent-r6.bin) memory initialization + ( please see [Native raminit compatibility] & [MRC memory compatibility] ) + +- Integrated graphics via libgfxinit and GENERIC_LINEAR_FRAMEBUFFER + (VGA/DVI-D/HDMI tested and working!) + +- Integrated graphics via extracted OpROM from Asus Bios 2203 + (VGA/DVI-D/HDMI tested and working!) + +- 1x PCIe GPU in PCIe-16x/8x/4x slots (tested using Zotac GeForce GTX + 750Ti and FirePro W5100) + + +## Native raminit compatibility + +- GSkill F3-2133C10D-16GAB(XMP,1.60v) 2x8Gb kit works at 1333Mhz instead of + XMP 2133Mhz ( tested with lshw, dmidecode & decode-dimms ) + +- Team Xtreem TXD38G2133HC9NDC01(XMP,1.50v) 2x4Gb kit works at 1600Mhz + instead of XMP 2133Mhz ( tested with lshw, dmidecode & decode-dimms ) + +- Kingston KVR1066D3N7K2/4G(JEDEC,1.50v) 2x4Gb kit works at 1066Mhz + ( tested with lshw, dmidecode & decode-dimms ), but the board only detects + half its RAM, because those DIMMs have Double Sided(DS) chips and seems only + Single Sided(SS) ones are fully detected. + +## MRC memory compatibility + +- Plug your memory DIMMs into blue slots only! (we hardcoded to disable the + black slots at file "src/mainboard/asus/p8z77-m_pro/romstage.c" in function + mainboard_fill_pei_data(), filling struct ".spd_addresses" ) + +- GSkill F3-2133C10D-16GAB(XMP,1.60v) 2x8Gb kit works at 1333Mhz instead of + XMP 2133Mhz ( tested with decode-dimms, lshw & dmidecode shows no + frequency info ) + +- Team Xtreem TXD38G2133HC9NDC01(XMP,1.50v) 2x4Gb kit works at 1600Mhz + instead of XMP 2133Mhz ( tested with decode-dimms, lshw & dmidecode + shows no frequency info ) + +- Kingston KVR1066D3N7K2/4G(JEDEC,1.50v) 2x4Gb kit works at 1066Mhz + ( tested with decode-dimms, lshw & dmidecode shows no freq info ) but the + board only detects half its RAM, as those DIMMs have Double Sided(DS) + chips and seems only Single Sided(SS) ones are fully detected. + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | ++------------------+--------------------------------------------------+ +| Southbridge | bd82x6x | ++------------------+--------------------------------------------------+ +| CPU | model_206ax / model_306ax | ++------------------+--------------------------------------------------+ +| Super I/O | Nuvoton NCT6779D | ++------------------+--------------------------------------------------+ +| EC | None | ++------------------+--------------------------------------------------+ +| Coprocessor | Intel Management Engine | ++------------------+--------------------------------------------------+ +``` + +## Extra resources + +- [Flash chip datasheet][W25Q64FVA1Q] + +[ASUS P8Z88-M Pro]: https://www.asus.com/Motherboards/P8Z77M_PRO/ +[W25Q64FVA1Q]: https://www.winbond.com/resource-files/w25q64fv%20revs%2007182017.pdf +[flashrom]: https://flashrom.org/Flashrom diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig b/src/mainboard/asus/p8z77-m_pro/Kconfig new file mode 100644 index 0000000..1e2a440 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Kconfig @@ -0,0 +1,164 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +if BOARD_ASUS_P8Z77_M_PRO + +config BOARD_SPECIFIC_OPTIONS + def_bool y + select BOARD_ROMSIZE_KB_8192 + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_INT15 + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT + select MAINBOARD_HAS_LIBGFXINIT + select INTEL_GMA_HAVE_VBT + select SUPERIO_NUVOTON_NCT6779D + select DRIVERS_ASMEDIA_ASPM_BLACKLIST # Board use a ASM1061(eSATA) +# select HAVE_IFD_BIN # uncomment if needed +# select HAVE_ME_BIN # uncomment if needed + +config MAINBOARD_DIR + string + default "asus/p8z77-m_pro" + +config MAINBOARD_PART_NUMBER + string + default "P8Z77-M PRO" + +config INTEL_GMA_ADD_VBT + def_bool y + +# This is used by libgfxinit. Comment it if you prefer to use VGA OpROMs +config INTEL_GMA_VBT_FILE + string + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" + +# This is used OpROMs, not sure for libgfxinit +config VGA_BIOS_ID + string + default "8086,0152" # i5-3470T ( HD Graphics 2500 GT1 ) + +# This is used just in case you use OpROMs and not libgfxinit +#config VGA_BIOS_FILE +# string +# default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/pci8086,0152.rom" +# + +# Set this to use your IGP as primary display instead of the GPU +config ONBOARD_VGA_IS_PRIMARY + def_bool n + +config DRAM_RESET_GATE_GPIO + int + default 60 + +config MAX_CPUS + int + default 8 + +# This board works with both Native RAM Init + MRC blob. Use NRI as default. +config USE_NATIVE_RAMINIT + def_bool y + +# +# We dont use USB2.0 (EHCI) debugging. Uncomment it if you need. +# idx1 -> 00:1d.0 USB controller [0c03]: Intel Corporation 7 Series/C216 +# Chipset Family USB Enhanced Host Controller #1 [8086:1e26] (rev 04) +# idx2 -> 00:1a.0 USB controller [0c03]: Intel Corporation 7 Series/C216 +# Chipset Family USB Enhanced Host Controller #2 [8086:1e2d] (rev 04) +# +#config USBDEBUG_HCD_INDEX +# int +# default 2 + +config USE_OPTION_TABLE + def_bool y + +config IFD_BIN_PATH + string + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" + +config ME_BIN_PATH + string + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin" + +# +# Uncomment if you need to partial-write parts of the bios image +# +#config IFD_SECTION +# string +# default "0x00000000:00000fff" +# +#config IFD_BIOS_SECTION +# string +# default "0x00180000:007fffff" +# +#config IFD_ME_SECTION +# string +# default "0x00001000:0017ffff" +# + +# Check Intel ME .bin file to be sure it's valid +config CHECK_ME + def_bool y + +config GENERATE_SMBIOS_TABLES + def_bool y + +config MAINBOARD_VERSION + string + default "1.01" # our board revision is v1.01 + +config MAINBOARD_SMBIOS_MANUFACTURER + string + default "ASUS" + +config MAINBOARD_SMBIOS_PRODUCT_NAME + string + default "P8Z77-M PRO" + +# This board has four memory DIMMS +config DIMM_MAX + int + default 4 + +# This board has a power button, it does not power-on via a +# jumper as other devboards. +config POWER_BUTTON_DEFAULT_ENABLE + def_bool y + +if USE_NATIVE_RAMINIT + config MMCONF_BASE_ADDRESS + hex + default 0xf8000000 + help + Set MMCONF_BASE_ADDRESS to 0xf8000000. It was already done for some + boards, but not all. The Sandy Bridge chipset code assumes 64 pci + buses behind MMCONF. See: + src/northbridge/sandybridge/bootblock.c:bootblock_northbridge_init() + Therefore, only 64MiB of physical address space is required. + Increasing the address allows to use additional 128MiB of MMIO space + to use the Intel IGP and a PEG at the same time. Previously it wasn't + possible to use both at the same time, as two 256MiB areas won't fit + into MMIO space. +endif # MRC requires fixed MMCONF address at 0xf0000000 + +endif # BOARD_ASUS_P8Z77_M_PRO diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig.name b/src/mainboard/asus/p8z77-m_pro/Kconfig.name new file mode 100644 index 0000000..c492094 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Kconfig.name @@ -0,0 +1,17 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +config BOARD_ASUS_P8Z77_M_PRO + bool "P8Z77-M PRO" diff --git a/src/mainboard/asus/p8z77-m_pro/Makefile.inc b/src/mainboard/asus/p8z77-m_pro/Makefile.inc new file mode 100644 index 0000000..4df65aa --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Makefile.inc @@ -0,0 +1,21 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software: you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation, either version 2 of the License, or +## (at your option) any later version. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +romstage-y += gpio.c + +# as we using libgfxinit, we need to include this +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads + diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl b/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl new file mode 100644 index 0000000..3a69621 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl @@ -0,0 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Method(_WAK,1) +{ + Return(Package(){0,0}) +} + +Method(_PTS,1) +{ +} diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl b/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl new file mode 100644 index 0000000..cfecdc6 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl @@ -0,0 +1,18 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <drivers/pc80/pc/ps2_controller.asl> + diff --git a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c new file mode 100644 index 0000000..4dd59d9 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c @@ -0,0 +1,47 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/bd82x6x/nvs.h> +#include <option.h> + +void acpi_create_gnvs(global_nvs_t *gnvs) +{ + /* + * Keep USB ports powered in S3 by default, because the user may have + * booted using a LiveUSB and, in that way, won't get problems resuming + * from S3. Also, the user may want to charge a mobile phone while + * suspended... so keep the USB ports always powered on! + */ + gnvs->s3u0 = 1; + gnvs->s3u1 = 1; + + /* Disable/enable USB ports in S5 suspend */ + int usbPoweredS5 = 0; + get_option ( &usbPoweredS5, "usb_powered_on_s5" ); + usbPoweredS5 = usbPoweredS5 & 1; /* be sure is 0 or 1 only, not 3,4,5,etc... */ + gnvs->s5u0 = usbPoweredS5; + gnvs->s5u1 = usbPoweredS5; + + /* + * This is a desktop computer, so we have no "lid" really, so keep it as + * if where always open in a laptop. + */ + gnvs->lids = 1; + + gnvs->tcrt = 95; /* critical temp that will shutdown the pc == 95C degrees */ + gnvs->tpsv = 85; /* temp to start throttling the cpu == 85C */ +} + diff --git a/src/mainboard/asus/p8z77-m_pro/board_info.txt b/src/mainboard/asus/p8z77-m_pro/board_info.txt new file mode 100644 index 0000000..66e6f0d --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/board_info.txt @@ -0,0 +1,7 @@ +Category: desktop +Board URL: https://www.asus.com/Motherboards/P8Z77M_PRO/ +ROM package: DIP-8 +ROM protocol: SPI +ROM socketed: y +Flashrom support: y +Release year: 2013 diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.default b/src/mainboard/asus/p8z77-m_pro/cmos.default new file mode 100644 index 0000000..0635955 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/cmos.default @@ -0,0 +1,27 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +boot_option=Fallback +debug_level=Emergency +gfx_uma_size=224M +nmi=Enable +power_on_after_fail=Disable +sata_mode=AHCI +hyper_threading=Enable +#usb3_XXXXX options only used by MRC, not by Native RAM Init +usb3_mode=Enable +usb3_preOS_drv=Enable +usb3_streams=Enable +usb_powered_on_s5=Disable diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.layout b/src/mainboard/asus/p8z77-m_pro/cmos.layout new file mode 100644 index 0000000..a14c05f --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/cmos.layout @@ -0,0 +1,219 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +# ----------------------------------------------------------------- +entries + +# ----------------------------------------------------------------- +# Status Register A +# ----------------------------------------------------------------- +# Status Register B +# ----------------------------------------------------------------- +# Status Register C +#96 4 r 0 status_c_rsvd +#100 1 r 0 uf_flag +#101 1 r 0 af_flag +#102 1 r 0 pf_flag +#103 1 r 0 irqf_flag +# ----------------------------------------------------------------- +# Status Register D +#104 7 r 0 status_d_rsvd +#111 1 r 0 valid_cmos_ram +# ----------------------------------------------------------------- +# Diagnostic Status Register +#112 8 r 0 diag_rsvd1 + +# ----------------------------------------------------------------- +0 120 r 0 reserved_memory +#120 264 r 0 unused + +# ----------------------------------------------------------------- +# RTC_BOOT_BYTE (coreboot hardcoded) +384 1 e 3 boot_option +388 4 h 0 reboot_counter + +# ----------------------------------------------------------------- +# coreboot config options: console +#392 3 r 0 unused +395 4 e 4 debug_level +#399 1 r 0 unused +#400 8 r 0 reserved for century byte + +# coreboot config options: southbridge +408 1 e 1 nmi +409 2 e 5 power_on_after_fail +411 1 e 6 sata_mode + +# coreboot config options: northbridge +416 5 e 7 gfx_uma_size + +# coreboot config options: cpu +421 1 e 8 hyper_threading + +# usb3_xxxx are just used when using MRC blob to init ram/usb/pci. +# Not used when using Native RAM Init. +422 2 e 9 usb3_mode +424 1 e 10 usb3_preOS_drv +425 1 e 11 usb3_streams +426 1 e 12 usb_powered_on_s5 + +# Sandy/Ivy Bridge MRC Scrambler Seed values +# Used in src/northbridge/intel/sandybridge/raminit_mrc.c +# and MUST NOT be covered by checksum! +896 32 r 0 mrc_scrambler_seed +928 32 r 0 mrc_scrambler_seed_s3 +960 16 r 0 mrc_scrambler_seed_chk + + +# coreboot config options: check sums +992 16 h 0 check_sum + +# ----------------------------------------------------------------- + +enumerations +#ID value text + +# nmi +# Non Maskable Interrupt(NMI) support, which is an interrupt that may +# occur on a RAM or unrecoverable error. +# See coreboot/src/southbridge/intel/bd82x6x/lpc.c:pch_power_options() +1 0 Disable +1 1 Enable + +# not sure that is enum 2 but just in case ... +2 0 Enable +2 1 Disable + +# boot_option +3 0 Fallback +3 1 Normal + +# debug_level +# Is the verbosity level for debugging purposes. +# See coreboot/src/console/init.c:init_log_level() +# I recommend to set it to "Emergency" for the BIOS release version. +4 0 Emergency +4 1 Alert +4 2 Critical +4 3 Error +4 4 Warning +4 5 Notice +4 6 Info +4 7 Debug +4 8 Spew + +# power_on_after_fail +# What happens when the power goes doen in your house and,then,recovers power? +# Should the BIOS kept the computer OFF or turn it on? ) +# why 2 bits? it should be a bool according to : +# https://www.coreboot.org/Nvramtool#Commonly_used_CMOS.2FNVRAM_options +# See coreboot/src/southbridge/intel/common/smihandler.c:southbridge_smi_sleep +# coreboot/src/southbridge/intel/bd82x6x/lpc.c:pch_power_options() +# +5 0 Disable +5 1 Enable +5 2 Keep + +# +# sata_mode +# Used in src/southbridge/intel/bd82x6x/sata.c:sata_init() +# Serial ATA Advanced Host Controller Interface(AHCI) for modern HDD/SDD +# or IDE-Compatible for Windows XP, etc... +# See https://en.wikipedia.org/wiki/Advanced_Host_Controller_Interface +# +6 0 AHCI +6 1 Compatible + +# gfx_uma_size ( == Unified Memory the Intel IGP can use for graphics & +# rendering, using the system's DDR3 ). +# Used in src/northbridge/intel/sandybridge/early_init.c +# at function sandybridge_setup_graphics() +# If you have enough RAM, I recommend not to keep it below 224M, as the IGP +# won't be able to render 3D things well due to not enough VRAM memory! +# +7 0 32M +7 1 64M +7 2 96M +7 3 128M +7 4 160M +7 5 192M +7 6 224M +7 7 256M +7 8 288M +7 9 320M +7 10 352M +7 11 384M +7 12 416M +7 13 448M +7 14 480M +7 15 512M +7 16 1024M + +# hyper_threading +# Used in src/cpu/intel/hyperthreading/intel_sibling.c:intel_sibling_init() +# Some Intel CPUs have the ability to execute more than a thread per core +# in an effective way. +# See this: https://en.wikipedia.org/wiki/Hyper-threading +# I recommend to keep it always Enable +# +8 0 Disable +8 1 Enable + +# usb3_mode +# Disable = Use the port always as USB 2.0 for compatibility +# Enable = Use the port always as USB 3.0 for speed +# Auto = Initialize the port as USB 2.0, until the OS loads +# xHCI USB 3.0 driver +# SmartAuto = Same as Auto but, if the OS loads the xHCI USB 3.0 driver +# and the computer is reset, keep the USB 3.0 mode. +# +# I recommend to set this to Enable, as the ASUS P8Z77-M Pro Gen3 has +# four USB3.0 ports and the user can plug some device into any other +# of the USB2 port for compatibility. +# +9 0 Disable +9 1 Enable +9 2 Auto +9 3 SmartAuto + +# usb3_preOS_drv +# Load or not pre-OS xHCI bios driver +# I recommend to set it to Enable, so you could use full-speed on some +# devices prior to booting the operating system ( like an iPXE USB dongle ) +# +10 0 Disable +10 1 Enable + +# usb3_streams +# Enablong streams provide more speed (as they can use 64Kb packets), +# but they might cause incompatibilities with some devices. +# +11 0 Disable +11 1 Enable + +# usb_powered_on_s5 +# Option to let the user to decide if wants to keep the USB ports enabled on +# S5(power off computer) for instance to charge a mobile phone while the +# computer is shut down. +# +12 0 Disable +12 1 Enable + +# ----------------------------------------------------------------- +# <startBit[must be byte-aligned]> <endBit[must be byte aligned]> +# <bit where to start storing checksum[must be 16bits-aligned]> +checksums + +checksum 392 431 992 diff --git a/src/mainboard/asus/p8z77-m_pro/data.vbt b/src/mainboard/asus/p8z77-m_pro/data.vbt new file mode 100644 index 0000000..34679b3 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb new file mode 100644 index 0000000..fd1f5ab --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -0,0 +1,125 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" + register "gfx.link_frequency_270_mhz" = "0" + register "gfx.ndid" = "3" + register "gfx.use_spread_spectrum_clock" = "0" + register "gpu_cpu_backlight" = "0x00000000" + register "gpu_dp_b_hotplug" = "4" + register "gpu_dp_c_hotplug" = "4" + register "gpu_dp_d_hotplug" = "4" + register "gpu_panel_port_select" = "0" + register "gpu_panel_power_backlight_off_delay" = "0" + register "gpu_panel_power_backlight_on_delay" = "0" + register "gpu_panel_power_cycle_delay" = "4" + register "gpu_panel_power_down_delay" = "0" + register "gpu_panel_power_up_delay" = "0" + register "gpu_pch_backlight" = "0x00000000" + device cpu_cluster 0x0 on + chip cpu/intel/model_206ax + register "c1_acpower" = "1" + register "c1_battery" = "1" + register "c2_acpower" = "3" + register "c2_battery" = "3" + register "c3_acpower" = "5" + register "c3_battery" = "5" + device lapic 0x0 on + end + device lapic 0xacac off + end + end + end + device domain 0x0 on + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH + register "c2_latency" = "0x0065" + register "docking_supported" = "0" + register "gen1_dec" = "0x000c0291" + register "gen2_dec" = "0x00000000" + register "gen3_dec" = "0x00000000" + register "gen4_dec" = "0x0000ff29" + register "p_cnt_throttling_supported" = "0" + register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" + register "pcie_port_coalesce" = "1" + register "sata_interface_speed_support" = "0x3" # 0x3=SATAIII + register "sata_port_map" = "0x3f" # Enable the 6 SATA ports on board + register "spi_lvscc" = "0x2005" + register "spi_uvscc" = "0x2005" + register "superspeed_capable_ports" = "0x0000000f" + register "xhci_overcurrent_mapping" = "0x00000c03" + register "xhci_switchable_ports" = "0x0000000f" # the four ports + device pci 14.0 on # USB 3.0 Controller + subsystemid 0x1043 0x84ca + end + device pci 16.0 on # Management Engine Interface 1 + subsystemid 0x1043 0x84ca + end + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT + device pci 19.0 off end # P8Z77-M Pro does not use "gbe.bin" + device pci 1a.0 on # USB2 EHCI #2 + subsystemid 0x1043 0x84ca + end + device pci 1b.0 on # High Definition Audio Audio controller + subsystemid 0x1043 0x8436 + end + device pci 1c.0 on # PCIe Port #1 + subsystemid 0x1043 0x84ca + end + device pci 1c.1 off end # PCIe Port #2 + device pci 1c.2 off end # PCIe Port #3 + device pci 1c.3 off end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 on # PCIe Port #6 + subsystemid 0x1043 0x84ca + end + device pci 1c.6 on # PCIe Port #7 + subsystemid 0x1043 0x84ca + end + device pci 1c.7 on # PCIe Port #8 + subsystemid 0x1043 0x84ca + end + device pci 1d.0 on # USB2 EHCI #1 + subsystemid 0x1043 0x84ca + end + device pci 1e.0 off end # PCI bridge(P8Z77-M Pro has no legacy PCI) + device pci 1f.0 on # LPC bridge PCI-LPC bridge + subsystemid 0x1043 0x84ca + chip drivers/pc80/tpm + device pnp 4e.0 on end # TPM module + end + end + device pci 1f.2 on # SATA Controller 1 + subsystemid 0x1043 0x84ca + end + device pci 1f.3 on # SMBus + subsystemid 0x1043 0x84ca + end + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal + end + device pci 00.0 on # Host bridge Host bridge + subsystemid 0x1043 0x84ca + end + device pci 01.0 on # PCIe Bridge for discrete graphics + subsystemid 0x1043 0x84ca + end + device pci 02.0 on # Internal graphics VGA controller + subsystemid 0x1043 0x84ca + end + end +end diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl new file mode 100644 index 0000000..b0db386 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -0,0 +1,46 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 + +#include <arch/acpi.h> +DefinitionBlock( + "dsdt.aml", + "DSDT", + 0x02, /* DSDT revision: ACPI 2.0 and up */ + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20141018 /* OEM revision */ +) +{ + /* Some macros */ + #include "acpi/platform.asl" + #include "acpi/superio.asl" + #include <cpu/intel/common/acpi/cpu.asl> + #include <southbridge/intel/bd82x6x/acpi/platform.asl> + /* NVS and variables. */ + #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> + #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + + Device (_SB.PCI0) + { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } +} diff --git a/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads b/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads new file mode 100644 index 0000000..622ccdd --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads @@ -0,0 +1,33 @@ +-- +-- This file is part of the coreboot project. +-- +-- Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +-- +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation, either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + -- Discovered the correct ports were HDMI 1&3 just using + -- "intelvbttool --inoprom vga.rom -d" and looking for "dvo_port" + ports : constant Port_List := + (HDMI1, -- DVI-D port on rear(managed through HDMI, it's not an error!) + HDMI3, -- real HDMI port on rear + Analog, -- VGA port on rear + others => Disabled); + +end GMA.Mainboard; diff --git a/src/mainboard/asus/p8z77-m_pro/gpio.c b/src/mainboard/asus/p8z77-m_pro/gpio.c new file mode 100644 index 0000000..458fff5 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/gpio.c @@ -0,0 +1,200 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/common/gpio.h> + +/* generated by autoport */ + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_NATIVE, + .gpio3 = GPIO_MODE_NATIVE, + .gpio4 = GPIO_MODE_NATIVE, + .gpio5 = GPIO_MODE_NATIVE, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_NATIVE, + .gpio10 = GPIO_MODE_NATIVE, + .gpio11 = GPIO_MODE_NATIVE, + .gpio12 = GPIO_MODE_GPIO, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_NATIVE, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_NATIVE, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_GPIO, + .gpio22 = GPIO_MODE_NATIVE, + .gpio23 = GPIO_MODE_NATIVE, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_NATIVE, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_GPIO, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_OUTPUT, + .gpio12 = GPIO_DIR_OUTPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_OUTPUT, + .gpio16 = GPIO_DIR_INPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio21 = GPIO_DIR_INPUT, + .gpio24 = GPIO_DIR_OUTPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_OUTPUT, + .gpio29 = GPIO_DIR_OUTPUT, + .gpio31 = GPIO_DIR_OUTPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio8 = GPIO_LEVEL_HIGH, + .gpio12 = GPIO_LEVEL_LOW, + .gpio15 = GPIO_LEVEL_LOW, + .gpio24 = GPIO_LEVEL_LOW, + .gpio28 = GPIO_LEVEL_LOW, + .gpio29 = GPIO_LEVEL_HIGH, + .gpio31 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio1 = GPIO_INVERT, + .gpio13 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_GPIO, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_NATIVE, + .gpio36 = GPIO_MODE_NATIVE, + .gpio37 = GPIO_MODE_NATIVE, + .gpio38 = GPIO_MODE_NATIVE, + .gpio39 = GPIO_MODE_NATIVE, + .gpio40 = GPIO_MODE_NATIVE, + .gpio41 = GPIO_MODE_NATIVE, + .gpio42 = GPIO_MODE_NATIVE, + .gpio43 = GPIO_MODE_NATIVE, + .gpio44 = GPIO_MODE_NATIVE, + .gpio45 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_GPIO, + .gpio47 = GPIO_MODE_NATIVE, + .gpio48 = GPIO_MODE_NATIVE, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_NATIVE, + .gpio51 = GPIO_MODE_NATIVE, + .gpio52 = GPIO_MODE_NATIVE, + .gpio53 = GPIO_MODE_NATIVE, + .gpio54 = GPIO_MODE_NATIVE, + .gpio55 = GPIO_MODE_NATIVE, + .gpio56 = GPIO_MODE_NATIVE, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_NATIVE, + .gpio60 = GPIO_MODE_NATIVE, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio32 = GPIO_DIR_OUTPUT, + .gpio33 = GPIO_DIR_OUTPUT, + .gpio34 = GPIO_DIR_INPUT, + .gpio45 = GPIO_DIR_INPUT, + .gpio46 = GPIO_DIR_INPUT, + .gpio49 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_OUTPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio32 = GPIO_LEVEL_HIGH, + .gpio33 = GPIO_LEVEL_HIGH, + .gpio57 = GPIO_LEVEL_LOW, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_NATIVE, + .gpio65 = GPIO_MODE_NATIVE, + .gpio66 = GPIO_MODE_NATIVE, + .gpio67 = GPIO_MODE_NATIVE, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_NATIVE, + .gpio71 = GPIO_MODE_NATIVE, + .gpio72 = GPIO_MODE_GPIO, + .gpio73 = GPIO_MODE_NATIVE, + .gpio74 = GPIO_MODE_NATIVE, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio72 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/asus/p8z77-m_pro/hda_verb.c b/src/mainboard/asus/p8z77-m_pro/hda_verb.c new file mode 100644 index 0000000..d294474 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/hda_verb.c @@ -0,0 +1,91 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* generated by autoport */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ + 0x10438436, /* Subsystem ID */ + + 0x0000000f, /* Number of 4 dword sets */ + /* NID 0x01: Subsystem ID. */ + AZALIA_SUBVENDOR(0x0, 0x10438436), + + /* NID 0x11. */ + AZALIA_PIN_CFG(0x0, 0x11, 0x99430140), + + /* NID 0x12. */ + AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0), + + /* NID 0x14. */ + AZALIA_PIN_CFG(0x0, 0x14, 0x01014010), + + /* NID 0x15. */ + AZALIA_PIN_CFG(0x0, 0x15, 0x01011012), + + /* NID 0x16. */ + AZALIA_PIN_CFG(0x0, 0x16, 0x01016011), + + /* NID 0x17. */ + AZALIA_PIN_CFG(0x0, 0x17, 0x01012014), + + /* NID 0x18. */ + AZALIA_PIN_CFG(0x0, 0x18, 0x01a19850), + + /* NID 0x19. */ + AZALIA_PIN_CFG(0x0, 0x19, 0x02a19c60), + + /* NID 0x1a. */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x0181305f), + + /* NID 0x1b. */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x02214c20), + + /* NID 0x1c. */ + AZALIA_PIN_CFG(0x0, 0x1c, 0x411111f0), + + /* NID 0x1d. */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x4005e601), + + /* NID 0x1e. */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x01456130), + + /* NID 0x1f. */ + AZALIA_PIN_CFG(0x0, 0x1f, 0x411111f0), + 0x80862806, /* Codec Vendor / Device ID: Intel */ + 0x80860101, /* Subsystem ID */ + + 0x00000004, /* Number of 4 dword sets */ + /* NID 0x01: Subsystem ID. */ + AZALIA_SUBVENDOR(0x3, 0x80860101), + + /* NID 0x05. */ + AZALIA_PIN_CFG(0x3, 0x05, 0x58560010), + + /* NID 0x06. */ + AZALIA_PIN_CFG(0x3, 0x06, 0x58560020), + + /* NID 0x07. */ + AZALIA_PIN_CFG(0x3, 0x07, 0x18560030), +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/asus/p8z77-m_pro/mainboard.c b/src/mainboard/asus/p8z77-m_pro/mainboard.c new file mode 100644 index 0000000..fdd8529 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/mainboard.c @@ -0,0 +1,39 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/device.h> +#include <drivers/intel/gma/int15.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <device/pci_type.h> +#include <device/pci_ops.h> + +static void mainboard_enable(struct device *dev) +{ + /* + * As the ASUS P8Z77-M Pro is a desktop motherboard, there is no + * internal LCD connection to eDP/LVDS, so we must use + * GMA_INT15_ACTIVE_LFP_NONE as first parameter. More info at: + * https://github.com/coreboot/coreboot/tree/master/util/autoport + */ + install_intel_vga_int15_handler ( GMA_INT15_ACTIVE_LFP_NONE, + GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0 ); +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable +}; + diff --git a/src/mainboard/asus/p8z77-m_pro/romstage.c b/src/mainboard/asus/p8z77-m_pro/romstage.c new file mode 100644 index 0000000..8f3258c --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/romstage.c @@ -0,0 +1,304 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <stdint.h> +#include <string.h> +#include <timestamp.h> +#include <arch/byteorder.h> +#include <device/mmio.h> +#include <device/pci_ops.h> +#include <device/pnp_ops.h> +#include <console/console.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <southbridge/intel/common/gpio.h> + +#include <superio/nuvoton/common/nuvoton.h> +#include <superio/nuvoton/nct6779d/nct6779d.h> + +#include <option.h> + +#if CONFIG(USE_NATIVE_RAMINIT) + #include <northbridge/intel/sandybridge/raminit_native.h> +#else + #include <northbridge/intel/sandybridge/raminit.h> + #include <northbridge/intel/sandybridge/pei_data.h> +#endif + +void pch_enable_lpc(void) +{ + pci_write_config16(PCH_LPC_DEV, LPC_EN, + CNF1_LPC_EN | CNF2_LPC_EN | MC_LPC_EN | + KBC_LPC_EN | FDD_LPC_EN | LPT_LPC_EN | + COMB_LPC_EN | COMA_LPC_EN); + + /* Generic Decode Ranges 1/2/3/4. Already in devicetree.cb */ + pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x000c0291u); + pci_write_config32(PCH_LPC_DEV, LPC_GEN2_DEC, 0x00000000u); + pci_write_config32(PCH_LPC_DEV, LPC_GEN3_DEC, 0x00000000u); + pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0000ff29u); + + /* 10000b=0x10 to enable 2F8h – 2FFh (COMB->COM2) */ + pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0010u); +} + +void mainboard_rcba_config(void) +{ +} + +const struct southbridge_usb_port mainboard_usb_ports[] = { + /* {enable, current, oc_pin} */ + { 1, 2, 0 }, /* USB3 front internal header */ + { 1, 2, 0 }, /* USB3 front internal header */ + { 1, 2, 1 }, /* USB3 rear, ETH top */ + { 1, 2, 1 }, /* USB3 rear, ETH botton */ + { 1, 2, 2 }, /* USB2 rear, PS2 top */ + { 1, 2, 2 }, /* USB2 read, PS2 bottom */ + { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ + { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ + { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ + { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ + { 0, 2, 6 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ + { 0, 2, 5 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ + { 0, 2, 5 }, /* ??? . Let's disable it */ + { 0, 2, 6 } /* ??? . Let's disable it */ +}; /* NOTE: Asmedia ASM1042 USB3 aren't managed by this, but by PCIe driver! */ + +void mainboard_early_init(int s3resume) +{ +} + +void mainboard_config_superio(void) +{ + static const pnp_devfn_t GLOBAL_PSEUDO_DEV = PNP_DEV(0x2e, 0); + + /* Begin configuration */ + nuvoton_pnp_enter_conf_state(GLOBAL_PSEUDO_DEV); + + /* + * Config PS/2 keyboard & mouse. + * See section "21.5 Configuration Register -> Logical Device 5 + * ( Keyboard Controller)", page 315-316 on Nuvoton 6779D datasheet. + * pnp_set_iobase() funcs write 16bits value ( writes 1st the high part ). + * pnp_set_irq() funcs write 8bits value. + * pnp_set_drq() funcs write (8bits value & 0xff). + * The "&0xff" is cuz some systems may define CHAR_SIZE=9, so need a mask. + * Values are set accoding to the Asus Bios 2203 defaults, extracted using + * "superiotool -d" and checking Nuvoton 6779D data sheet. + * It's needed to include "#include <drivers/pc80/pc/ps2_controller.asl>" + * in superio.asl / DSDT.asl, and also to specify DRIVERS_PS2_KEYBOARD=y + * in your config file. + */ + static const pnp_devfn_t KBC_DEV = PNP_DEV(0x2e, NCT6779D_KBC); + pnp_set_logical_device ( KBC_DEV ); + + pnp_set_enable(KBC_DEV, 1); /* enable logical device */ + pnp_set_iobase(KBC_DEV, 0x60u, 0x0060u); /* KBC1 IO base address (KBD) */ + pnp_set_iobase(KBC_DEV, 0x62u, 0x0064u); /* KBC2 IO base address (AUX) */ + pnp_set_drq(KBC_DEV, 0x70u, 0x01u); /* Keyboard IRQ=1 */ + pnp_set_drq(KBC_DEV, 0x72u, 0x0cu); /* Mouse IRQ=12 */ + pnp_set_drq(KBC_DEV, 0xf0u, 0x82u); + /* KB 12Mhz + Disable Port 92 + Gate A20 hw speedup + soft KBRST */ + /* Defval=0x83(KBRST by hw instead of sw). Asus Bios 2203 has 0x82 */ + + /* + * Config several SuperIO ACPI things. + * See section "21.10 Configuration Register -> Logical Device A (ACPI)", + * page 340-341 + */ + static const pnp_devfn_t ACPI_DEV = PNP_DEV(0x2e, NCT6779D_ACPI); + pnp_set_logical_device ( ACPI_DEV ); + + uint8_t acp = (uint8_t)0U; + + /* + * We prefer the user to control "power on after fail" this via a NVRAM + * option instead of coreboot's make xconfig Maiboard-> + * POWER_STATE_OFF_AFTER_FAILURE / POWER_STATE_ON_AFTER_FAILURE / + * POWER_STATE_PREVIOUS_AFTER_FAILURE + */ + int powerOnAfterFail = 0; + get_option ( &powerOnAfterFail, "power_on_after_fail" ); + switch (powerOnAfterFail) { + case 2: + /* keep state before power off */ + acp = (uint8_t)0x40U; /* 01000000b=0x40 */ + break; + case 1: + /* enable: turn computer on after computer fail */ + acp = (uint8_t)0x20U; /* 00100000b=0x20 */ + break; + case 0: + default: + /* disable: turn off computer */ + acp = (uint8_t)0U; /* bits 6-5 to zero */ + break; + } + + /* + * Set "3VSBSW# enable bit" to keep RAM always powered on in S3 suspend, + * so do an OR mask 00010000b=0x10. + */ + acp |= (uint8_t)0x10u; + pnp_write_config ( ACPI_DEV, 0xe4u, acp ); + + /* + * Enable 0.5s keyboard delay after S3 suspend(EN_ONPSOUT-VBAT) to let + * devices to response better to power change. + */ + uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); + acpiDelay |= (uint8_t)0x10u; /* Bit 4: Use 0.5s delay, OR mask 10000b=0x10 */ + pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); + + /* End configuration */ + nuvoton_pnp_exit_conf_state(GLOBAL_PSEUDO_DEV); +} + +#if CONFIG(USE_NATIVE_RAMINIT) + void mainboard_get_spd(spd_raw_data *spd, bool id_only) + { + /* we got the index values(0x50-0x53) inspecting the SMBus */ + read_spd ( &spd[0], 0x50, id_only ); + read_spd ( &spd[1], 0x51, id_only ); + read_spd ( &spd[2], 0x52, id_only ); + read_spd ( &spd[3], 0x53, id_only ); + } +#else + int mainboard_should_reset_usb(int s3resume) + { + return !s3resume; + } + + void mainboard_fill_pei_data(struct pei_data *pei_data) + { + struct pei_data pd = + { + .pei_version = PEI_VERSION, + .mchbar = (uintptr_t)DEFAULT_MCHBAR, + .dmibar = (uintptr_t)DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = CONFIG_HPET_ADDRESS, + .rcba = (uintptr_t)DEFAULT_RCBABASE, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .thermalbase = 0xfed08000, + .system_type = 1, /* 0=Mobile, 1=Desktop/Server */ + .tseg_size = CONFIG_SMM_TSEG_SIZE, + /* SMBus ones mul by 2! + * Hardcoding 2x DIMMs at the BLUE slots only! + */ + .spd_addresses = { 0x00, 0xa2, 0x00, 0xa6 }, + .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, + /* The P8Z77-M Pro apparently uses an EC. + * Asus Bios 2203 shows "XUECA-016" + */ + .ec_present = 1, + /* The P8Z77-M Pro has gbe.bin data config section + * in its original BIOS. + */ + .gbe_enable = 0, + /* 0=both DIMM enabled; 1=disable dimm#A(black); + * 2=disable DIMM#B(blue); 3=disable both DIMMS. + */ + .dimm_channel0_disabled = 1, + /* 0=both DIMM enabled; 1=disable dimm#A(black); + * 2=disable DIMM#B(blue); 3=disable both DIMMS. + */ + .dimm_channel1_disabled = 1, + .max_ddr3_freq = 1600, /* 1333=sandy; 1600=Ivy */ + .usb_port_config = { + /* copyed mainboard_usb_ports array above and added cable len: + * {enabled, oc_pin, cable len 0x0080=<8inches/20cm} + */ + { 1, 0, 0x0080 }, /* USB3 front internal header */ + { 1, 0, 0x0080 }, /* USB3 front internal header */ + { 1, 1, 0x0080 }, /* USB3 ETH top connector */ + { 1, 1, 0x0080 }, /* USB3 ETH botton connector */ + { 1, 2, 0x0080 }, /* USB2 PS2 top connector */ + { 1, 2, 0x0080 }, /* USB2 PS2 botton connector */ + { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ + { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ + { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ + { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ + { 0, 6, 0x0080 }, /* USB2 internal header (USB78 on board) */ + { 0, 5, 0x0080 }, /* USB2 internal header (USB78 on board) */ + { 0, 5, 0x0080 }, /* ??? Lets disable it */ + { 0, 6, 0x0080 } /* ??? Lets disable it */ + }, + .usb3 = { + /* 0=Disable; 1=Enable(start at USB3 speed) + * 2=Auto(start as USB2 until OS) + * 3=Smart Auto(like #2 but keep speed on reboot) + */ + 1, + /* 4 bit switch mask. 0=not switchable, 1=switchable; + * Means once it's loaded the OS, it can swap ports + * from/to EHCI/xHCI + */ + 0xf, + 1, /* 0=No xHCI preOS driver; 1=xHCI preOS driver */ + /* 0=Don't use xHCI streams (less speed,more compatibility) + * 1=use xHCI streams for better speed (and less compatibility) + */ + 1 + }, + /* ASUS P8Z77-M Pro supports 1.35v DIMMs according to the manual */ + .ddr3lv_support = 1, + /* PCIe 3.0 support. As we use Ivy Bridge, let's enable this... + * but might cause some system inestability! + */ + .pcie_init = 1, + /* Command Rate. 0=Auto; 1=1N; 2=2N. + * Better leave it always at Auto for compatibility & stability. + */ + .nmode = 0, + /* DDR refresh rate. 0=Auto based on DRAM's temperature; + * 1=Normal rate; 2=Double rate for better stability. + */ + .ddr_refresh_rate_config = 0 + }; + + /* + * USB3 mode: + * 0 = Disable: work always as USB 2.0(ehci) + * 1 = Enable: work always as USB 3.0(xhci) + * 2 = Auto: work as USB2.0(ehci) until OS loads USB3 xhci driver + * 3 = Smart Auto : same than Auto, but if OS loads USB3 driver and + * reboots, it will keep the USB3.0 speed. + */ + int usb3Mode = 1; + get_option ( &usb3Mode, "usb3_mode" ); + pd.usb3.mode = (uint16_t)usb3Mode; + + /* Load USB3 pre-OS xHCI driver */ + int usb3PreOSDrv = 1; + get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); + pd.usb3.preboot_support = (uint16_t)usb3PreOSDrv; + + /* Use USB3 xHCI streams */ + int usb3Streams = 1; + get_option ( &usb3Streams, "usb3_streams" ); + pd.usb3.xhci_streams = (uint16_t)usb3Streams; + + /* copy the data to output PEI */ + *pei_data = pd; + } +#endif /* CONFIG(USE_NATIVE_RAMINIT) */ +
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: src/mainboards/asus: Add support for P8Z77-M PRO mainboard ......................................................................
Patch Set 1:
(92 comments)
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... File src/mainboard/asus/p8z77-m_pro/acpi_tables.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 34: usbPoweredS5 = usbPoweredS5 & 1; /* be sure is 0 or 1 only, not 3,4,5,etc... */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 44: gnvs->tcrt = 95; /* critical temp that will shutdown the pc == 95C degrees */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... File src/mainboard/asus/p8z77-m_pro/mainboard.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 32: install_intel_vga_int15_handler ( GMA_INT15_ACTIVE_LFP_NONE, space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 33: GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0 ); line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 33: GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0 ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 70: { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 71: { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 72: { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 73: { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 74: { 0, 2, 6 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 75: { 0, 2, 5 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 95: * pnp_set_iobase() funcs write 16bits value ( writes 1st the high part ). line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 98: * The "&0xff" is cuz some systems may define CHAR_SIZE=9, so need a mask. line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 99: * Values are set accoding to the Asus Bios 2203 defaults, extracted using 'accoding' may be misspelled - perhaps 'according'?
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 99: * Values are set accoding to the Asus Bios 2203 defaults, extracted using line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 101: * It's needed to include "#include <drivers/pc80/pc/ps2_controller.asl>" line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 109: pnp_set_iobase(KBC_DEV, 0x60u, 0x0060u); /* KBC1 IO base address (KBD) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 110: pnp_set_iobase(KBC_DEV, 0x62u, 0x0064u); /* KBC2 IO base address (AUX) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 114: /* KB 12Mhz + Disable Port 92 + Gate A20 hw speedup + soft KBRST */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 115: /* Defval=0x83(KBRST by hw instead of sw). Asus Bios 2203 has 0x82 */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 119: * See section "21.10 Configuration Register -> Logical Device A (ACPI)", line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 135: switch (powerOnAfterFail) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 163: acpiDelay |= (uint8_t)0x10u; /* Bit 4: Use 0.5s delay, OR mask 10000b=0x10 */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 171: void mainboard_get_spd(spd_raw_data *spd, bool id_only) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 180: int mainboard_should_reset_usb(int s3resume) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 185: void mainboard_fill_pei_data(struct pei_data *pei_data) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 188: { that open brace { should be on the previous line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 227: /* copyed mainboard_usb_ports array above and added cable len: line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 228: * {enabled, oc_pin, cable len 0x0080=<8inches/20cm} line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 230: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 231: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 233: { 1, 1, 0x0080 }, /* USB3 ETH botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 235: { 1, 2, 0x0080 }, /* USB2 PS2 botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 236: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 237: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 238: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 239: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 240: { 0, 6, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 241: { 0, 5, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 248: * 3=Smart Auto(like #2 but keep speed on reboot) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 251: /* 4 bit switch mask. 0=not switchable, 1=switchable; line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 252: * Means once it's loaded the OS, it can swap ports line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 256: 1, /* 0=No xHCI preOS driver; 1=xHCI preOS driver */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 257: /* 0=Don't use xHCI streams (less speed,more compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 258: * 1=use xHCI streams for better speed (and less compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 262: /* ASUS P8Z77-M Pro supports 1.35v DIMMs according to the manual */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 264: /* PCIe 3.0 support. As we use Ivy Bridge, let's enable this... line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 269: * Better leave it always at Auto for compatibility & stability. line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 282: * 2 = Auto: work as USB2.0(ehci) until OS loads USB3 xhci driver line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 283: * 3 = Smart Auto : same than Auto, but if OS loads USB3 driver and line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited before that close parenthesis ')'
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#2).
Change subject: src/mainboards/asus: Add support for P8Z77-M PRO mainboard ......................................................................
src/mainboards/asus: Add support for P8Z77-M PRO mainboard
Add support for ASUS P8Z77-M PRO mainboard Signed-off-by: Vlado Ciric vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,552 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: src/mainboards/asus: Add support for P8Z77-M PRO mainboard ......................................................................
Patch Set 4:
(38 comments)
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/acpi_... File src/mainboard/asus/p8z77-m_pro/acpi_tables.c:
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/acpi_... PS4, Line 49: } adding a line without newline at end of file
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 98: * The "&0xff" is cuz some systems may define CHAR_SIZE=9, so need a mask line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 101: * It's needed to include "#include <drivers/pc80/pc/ps2_controller.asl>" line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 109: pnp_set_iobase(KBC_DEV, 0x60u, 0x0060u); /* KBC1 IO base address (KBD) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 110: pnp_set_iobase(KBC_DEV, 0x62u, 0x0064u); /* KBC2 IO base address (AUX) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 114: /* KB 12Mhz + Disable Port 92 + Gate A20 hw speedup + soft KBRST */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 115: /* Defval=0x83(KBRST by hw instead of sw). Asus Bios 2203 has 0x82 */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 119: * See section "21.10 Configuration Register -> Logical Device A (ACPI)", line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 135: switch (powerOnAfterFail) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 163: acpiDelay |= (uint8_t)0x10u; /* Bit 4: Use 0.5s delay, OR mask 10000b=0x10 */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 171: void mainboard_get_spd(spd_raw_data *spd, bool id_only) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 180: int mainboard_should_reset_usb(int s3resume) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 185: void mainboard_fill_pei_data(struct pei_data *pei_data) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 188: { that open brace { should be on the previous line
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 227: /* copyed mainboard_usb_ports array above & added cable len: line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 228: * {enabled, oc_pin, cable len 0x0080=<8inches/20cm} line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 230: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 231: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 233: { 1, 1, 0x0080 }, /* USB3 ETH botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 235: { 1, 2, 0x0080 }, /* USB2 PS2 botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 236: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 237: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 238: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 239: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 240: { 0, 6, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 241: { 0, 5, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 248: * 3=Smart Auto(like #2 but keep speed on reboot) line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 251: /* 4 bit switch mask. 0=not switchable, 1=switchable; line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 252: * Means once it's loaded the OS, it can swap ports line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 256: 1, /* 0=No xHCI preOS driver; 1=xHCI preOS driver */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 257: /* 0=Don't use xHCI streams (less speed,more compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 258: * 1=use xHCI streams for better speed (and less compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 262: /* ASUS P8Z77-M Pro supports 1.35v DIMMs according to the manual */ line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 264: /* PCIe 3.0 support. As we use Ivy Bridge, let's enable this... line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 269: * Better leave it always at Auto for compatibility & stability. line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 282: * 2 = Auto: work as USB2.0(ehci) until OS loads USB3 xhci driver line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 283: * 3 = Smart Auto : same than Auto, but if OS loads USB3 driver and line over 80 characters
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 303: #endif /* CONFIG(USE_NATIVE_RAMINIT) */ adding a line without newline at end of file
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 11:
(28 comments)
https://review.coreboot.org/#/c/33328/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33328/6//COMMIT_MSG@10 PS6, Line 10: Signed-off-by: Vlado Cibic vladocb@protonmail.com We generally have a newline before the Signed-off-by line.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... File src/mainboard/asus/p8z77-m_pro/Kconfig:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 35: # select HAVE_IFD_BIN # uncomment if needed : # select HAVE_ME_BIN # uncomment if needed remove
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 49: his is used by libgfxinit. This is untrue.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 45: : config INTEL_GMA_ADD_VBT : def_bool y : : # This is used by libgfxinit. Comment it if you prefer to use VGA OpROMs : config INTEL_GMA_VBT_FILE : string : default "src/mainboard/$(MAINBOARDDIR)/data.vbt" "select INTEL_GMA_HAVE_VBT", does both these things.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 54: # Set this to use your IGP as primary display instead of the GPU : config ONBOARD_VGA_IS_PRIMARY : def_bool n No need to redefine this. You can do this in make nconfig
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 66: # This board works with both Native RAM Init + MRC blob. Use NRI as default. : config USE_NATIVE_RAMINIT : def_bool y No need to redefine this here.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 70: : # We dont use USB2.0 (EHCI) debugging. Uncomment it if you need. Just leaving it in here does not hurt.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 81: config USE_OPTION_TABLE : def_bool y Why override the default?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 84: config IFD_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" : : config ME_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin" Already default, remove.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 92: # : # Uncomment if you need to partial-write parts of the bios image : # : #config IFD_SECTION : # string : # default "0x00000000:00000fff" : # : #config IFD_BIOS_SECTION : # string : # default "0x00180000:007fffff" : # : #config IFD_ME_SECTION : # string : # default "0x00001000:0017ffff" Those seem unused in the code.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 108: config GENERATE_SMBIOS_TABLES : def_bool y no need to redefine this.
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 124: DIMM_MAX unused by the sandybridge code afaict. Remove
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 128: # This board has a power button, it does not power-on via a : # jumper as other devboards. : config POWER_BUTTON_DEFAULT_ENABLE : def_bool y There seems to be no code with this option. Remove?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/Kcon... PS11, Line 132: : if USE_NATIVE_RAMINIT : config MMCONF_BASE_ADDRESS : hex : default 0xf8000000 : help : Set MMCONF_BASE_ADDRESS to 0xf8000000. It was already done for some : boards, but not all. The Sandy Bridge chipset code assumes 64 pci : buses behind MMCONF. See: : src/northbridge/sandybridge/bootblock.c:bootblock_northbridge_init() : Therefore, only 64MiB of physical address space is required. : Increasing the address allows to use additional 128MiB of MMIO space : to use the Intel IGP and a PEG at the same time. Previously it wasn't : possible to use both at the same time, as two 256MiB areas won't fit : into MMIO space. : endif # MRC requires fixed MMCONF address at 0xf0000000 It was made common such that the bootblocks are compatible between the 2 codepaths. I'd increase 'register "pci_mmio_size"' in the devicetree.cb if you need more mmiospace, but it is quite surprising you're not having enough since the default is 2048M.
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/Makef... File src/mainboard/asus/p8z77-m_pro/Makefile.inc:
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/Makef... PS6, Line 18: : # as we using libgfxinit, we need to include this Remove this comment, as it is clear from the code.
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/cmos.... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/cmos.... PS6, Line 63: hyper_threading unused option in the code.
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/cmos.... PS6, Line 63: 421 1 e 8 hyper_threading : : # usb3_xxxx are just used when using MRC blob to init ram/usb/pci. : # Not used when using Native RAM Init. : 422 2 e 9 usb3_mode : 424 1 e 10 usb3_preOS_drv : 425 1 e 11 usb3_streams : 426 1 e 12 usb_powered_on_s5 Please use the same formatting (without tabs) as the rest?
https://review.coreboot.org/#/c/33328/6/src/mainboard/asus/p8z77-m_pro/cmos.... PS6, Line 165: src/cpu/intel/hyperthreading/intel_sibling.c:intel_sibling_init() the model_206ax code does not use this.
https://review.coreboot.org/#/c/33328/10/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/10/src/mainboard/asus/p8z77-m_pro/devi... PS10, Line 25: register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0" : register "gpu_panel_power_cycle_delay" = "4" : register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000" remove, default is 0.
https://review.coreboot.org/#/c/33328/10/src/mainboard/asus/p8z77-m_pro/devi... PS10, Line 49: register "docking_supported" = "0 remove, default is 0.
https://review.coreboot.org/#/c/33328/10/src/mainboard/asus/p8z77-m_pro/devi... PS10, Line 51: register "gen2_dec" = "0x00000000" : register "gen3_dec" = "0x00000000" remove, default is 0.
https://review.coreboot.org/#/c/33328/10/src/mainboard/asus/p8z77-m_pro/devi... PS10, Line 100: device pci 1f.0 on # LPC bridge PCI-LPC bridge Configure your superio below here.
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/mainb... File src/mainboard/asus/p8z77-m_pro/mainboard.c:
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/mainb... PS8, Line 19: #include <northbridge/intel/sandybridge/sandybridge.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <device/pci_type.h> : #include <device/pci_ops.h> unused?
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/4/src/mainboard/asus/p8z77-m_pro/romst... PS4, Line 84: mainboard_config_superio In romstage you just want the serial console to work. All other things are better done via the devicetree/ramstage.
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... PS8, Line 34: #if CONFIG(USE_NATIVE_RAMINIT) The codepaths can coexist without CPP
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... PS8, Line 49: 0x000c0291u Passing an int to a function expecting an unsigned int is well defined behaviour, there is a trivial conversion. I'd prefer not to needlessly clutter the notation.
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... PS8, Line 139: (uint8_t) It is expected C behaviour to discard higher bits, so no need to do that explicitly
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... PS8, Line 288: (uint16_t) it is expected C behaviour to remove higher bits. No need to do that explicitly.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... File src/mainboard/asus/p8z77-m_pro/acpi/ec.asl:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... PS11, Line 4: Copyright Copyright for an empty file ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... File src/mainboard/asus/p8z77-m_pro/acpi/superio.asl:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... PS11, Line 4: Copyright ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... PS11, Line 19: #include <timestamp.h> is it needed ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... PS11, Line 24: #include <console/console.h> used? please check the other includes
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/8/src/mainboard/asus/p8z77-m_pro/romst... PS8, Line 19: #include <timestamp.h> used ? please check the other includes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#12).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,442 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/12
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/33328/12/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/12/src/mainboard/asus/p8z77-m_pro/cmos... PS12, Line 167: # in an effective way. See this: trailing whitespace
https://review.coreboot.org/#/c/33328/12/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/12/src/mainboard/asus/p8z77-m_pro/roms... PS12, Line 171: read_spd(&spd[0], 0x50, id_only); /* got the 0x50-0x53 inspecting SMBus */ line over 80 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#13).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,442 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/13
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#14).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,442 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/14
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/33328/14/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/14/src/mainboard/asus/p8z77-m_pro/roms... PS14, Line 171: read_spd(&spd[0], 0x50, id_only); /* got the 0x50-0x53 inspecting SMBus */ line over 80 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#15).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,443 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/15
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#16).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,440 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/16
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#17).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,436 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/17
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#18).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,418 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/18
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/#/c/33328/18/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/18/src/mainboard/asus/p8z77-m_pro/devi... PS18, Line 125: end trailing whitespace
https://review.coreboot.org/#/c/33328/18/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/18/src/mainboard/asus/p8z77-m_pro/roms... PS18, Line 74: * See Nuvuton 6779D datasheet, section trailing whitespace
https://review.coreboot.org/#/c/33328/18/src/mainboard/asus/p8z77-m_pro/roms... PS18, Line 75: * "21.10 Configuration Register->Logical Device A (ACPI)", code indent should use tabs where possible
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#19).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,418 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/19
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/#/c/33328/19/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/19/src/mainboard/asus/p8z77-m_pro/roms... PS19, Line 75: * 21.10 Configuration Register->Logical Device A (ACPI), code indent should use tabs where possible
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#20).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,418 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/20
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#21).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,419 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/21
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/#/c/33328/21/src/mainboard/asus/p8z77-m_pro/main... File src/mainboard/asus/p8z77-m_pro/mainboard.c:
https://review.coreboot.org/#/c/33328/21/src/mainboard/asus/p8z77-m_pro/main... PS21, Line 29: GMA_INT15_PANEL_FIT_DEFAULT, trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#22).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,419 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/22
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 22: Code-Review+1
Patched! Thanks for the comments!
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 22:
(12 comments)
https://review.coreboot.org/#/c/33328/14/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/14/Documentation/mainboard/asus/p8z77-... PS14, Line 47: Using MRC.bin, : seems the maximum allocable real size is 32Mb mrc.bin indeed reconfigures this regardless.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... PS22, Line 118: doen down
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... PS22, Line 162: 7 16 1024M Every setting larger than 512M is reserved according to the datasheet, so please remove. It also just seems wrong with it linearly increasing with 32M per bit.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 96: device pnp 2e.2 off end # UART A there is a COM port on the board?
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 100: drq 0x30 = 1 # Enable device When a LDN is set to 'on' it will set the right bit in 0x030.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 103: drq 0x70 = 1 # Keyboard IRQ : drq 0x72 = 12 # Mouse IRQ Those are irq's
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 127: 4e.0 most often 0c31 is set here as a dummy because PNP0C31 ACPI ID.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/hda_... File src/mainboard/asus/p8z77-m_pro/hda_verb.c:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/hda_... PS22, Line 30: : /* NID 0x11. */ those comments are pretty redundant. Please remove
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 65: mainboard_config_superio You probably want to enable serial on the COM port here.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 81: /* Setup "power on after fail" via NVRAM option */ : uint8_t acp; : int powerOnAfterFail = 0; : get_option(&powerOnAfterFail, "power_on_after_fail"); : : switch (powerOnAfterFail) { : case 2: : /* keep state before power off */ : acp = 0x40; /* 01000000b=0x40 */ : break; : case 1: : /* enable: turn computer on after computer fail */ : acp = 0x20; /* 00100000b=0x20 */ : break; : case 0: : default: : /* disable: turn off computer */ : acp = 0; /* bits 6-5 to zero */ : break; : } This is not mainboard specific. Move it to the superio code.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 101: : /* Set "3VSBSW# enable bit" to keep RAM powered on S3 suspend */ : acp |= 0x10; : pnp_write_config(ACPI_DEV, 0xe4, acp); Setting this in the devicetree (irq 0xe4 = ...) should work too.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 110: #if CONFIG(USE_NATIVE_RAMINIT) Remove
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 22: -Code-Review
(10 comments)
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... PS22, Line 162: 7 16 1024M
Every setting larger than 512M is reserved according to the datasheet, so please remove. […]
I just copied the settings from the original Bios, but that's interesting! I'm gonna try to add values in 32mb increment and test if I can reach 1024M with this board with multiple OS! thx!
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 96: device pnp 2e.2 off end # UART A
there is a COM port on the board?
Yep, but saly the one I bought has bended pins so I can't test it 8(
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 100: drq 0x30 = 1 # Enable device
When a LDN is set to 'on' it will set the right bit in 0x030.
Ooops, you're right!
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 103: drq 0x70 = 1 # Keyboard IRQ : drq 0x72 = 12 # Mouse IRQ
Those are irq's
Yep, I should change that to "irq" and not "drq".
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/devi... PS22, Line 127: 4e.0
most often 0c31 is set here as a dummy because PNP0C31 ACPI ID.
Interesting.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/hda_... File src/mainboard/asus/p8z77-m_pro/hda_verb.c:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/hda_... PS22, Line 30: : /* NID 0x11. */
those comments are pretty redundant. […]
Yep, autoport placed it there. I'll remove it.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 65: mainboard_config_superio
You probably want to enable serial on the COM port here.
Can't, I'm afraid my board's COM pins are bended and can't test well...
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 81: /* Setup "power on after fail" via NVRAM option */ : uint8_t acp; : int powerOnAfterFail = 0; : get_option(&powerOnAfterFail, "power_on_after_fail"); : : switch (powerOnAfterFail) { : case 2: : /* keep state before power off */ : acp = 0x40; /* 01000000b=0x40 */ : break; : case 1: : /* enable: turn computer on after computer fail */ : acp = 0x20; /* 00100000b=0x20 */ : break; : case 0: : default: : /* disable: turn off computer */ : acp = 0; /* bits 6-5 to zero */ : break; : }
This is not mainboard specific. Move it to the superio code.
Yep, better. thx.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 101: : /* Set "3VSBSW# enable bit" to keep RAM powered on S3 suspend */ : acp |= 0x10; : pnp_write_config(ACPI_DEV, 0xe4, acp);
Setting this in the devicetree (irq 0xe4 = ...) should work too.
Ack
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/roms... PS22, Line 110: #if CONFIG(USE_NATIVE_RAMINIT)
Remove
Oh, yep. Both paths(NRI+MRC) can work without that CPP.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#23).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 20 files changed, 1,376 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/23
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 32:
(3 comments)
Patch Set 30: Code-Review+1
(5 comments)
Looks much better, thank you!
Apologies if my previous review sounded harsh, I did not intend it to be.
Feel free to reply to any comments :D
Nah, don't worry, you didn't sound harsh. I'm just intimidated by the whole system: this is my first time with Gerrit, Git, Coreboot, Tianocore, OSS, linux... I feel as if I were running the opposite way on a highway... but... nope :))
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.default:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... PS23, Line 23: usb3_mode=Enable : usb3_preOS_drv=Enable : usb3_streams=Enable
I feel I might have expressed myself wrong. […]
I think these options should be present, because:
1. The original ASUS bios has them, so I figure out for a reason.
2. I've found these options useful to get the MRC working: I have multiple USB3 devices(pendrives,GbE,IoT,PXE dongles,cameras,etc) and some legacy devices work but others had USB3 incompatibilities with xHCI or streams... so I had to tweak these options in order to make devices to work properly. Without those options, I would never be able to use them. So, for the end user, I think it's good to have control on these options.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... PS22, Line 162: 7 16 1024M
I just copied the settings from the original Bios, but that's interesting! I'm gonna try to add valu […]
I've added a few more values in 32Mb increments and seems 1024M is working under linux Mint now! (tested with dmesg).
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... PS23, Line 72: /* : * Config several SuperIO ACPI things. : * See Nuvuton 6779D datasheet, section : * "21.10 Configuration Register->Logical Device A (ACPI)", : * page 340-341 : */
Not needed. […]
Tested a couple times. The 3VSBSW is **definitively** needed. Thanks for pointing it out tho ;)
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 34: Code-Review+1
(1 comment)
Thanks for all your comments! I've reviewed & tested all and I think the code is ready for merge!
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG@10 PS32, Line 10:
Nice. […]
Filled the Documentation/mainboard/asus/p8z77-m_pro.md explaning about.
I cannot test COM because my board has the connector's pins bent. I neither have an EHCI debugging device, so can't test.
All the rest (sata,nri/mrc,pcie,igp,net,audio,usb2/3,seabios/tianocore) is working well!
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#35).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,208 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/35
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 35: Code-Review+1
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#36).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,206 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/36
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#37).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,204 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/37
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#38).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,205 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/38
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#39).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,205 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/39
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#40).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,205 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/40
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 40: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 40: Code-Review+1
(9 comments)
Looks very nice!
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG@10 PS32, Line 10:
Filled the […]
Even MRC with 4 DIMMs is working?
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 110: Gb Gigabit or GigaByte?
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 111: I'd avoid spaces inside parentheses
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.default:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... PS23, Line 23: usb3_mode=Enable : usb3_preOS_drv=Enable : usb3_streams=Enable
I think these options should be present, because: […]
I see, then it's a good idea to keep them.
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/cmos... PS38, Line 165: I'd suggest using spaces on this file, since it's what it uses
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... PS38, Line 18: : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4" not sure if those are needed, the board doesn't seem to use displayport
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/hda_... File src/mainboard/asus/p8z77-m_pro/hda_verb.c:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/hda_... PS38, Line 19: /* generated by Autoport */ Please remove this
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... PS23, Line 72: /* : * Config several SuperIO ACPI things. : * See Nuvuton 6779D datasheet, section : * "21.10 Configuration Register->Logical Device A (ACPI)", : * page 340-341 : */
Tested a couple times. The 3VSBSW is **definitively** needed. […]
AFAIK, most nuvoton/winbond SuperIOs have this option that needs to be enabled.
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/roms... PS38, Line 106: sure is "ensure it is", or "make sure it is"
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#41).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,200 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/41
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 41: Code-Review+1
(3 comments)
Patch Set 40: Code-Review+1
(9 comments)
Looks very nice!
thx for all your help!
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG@10 PS32, Line 10:
Even MRC with 4 DIMMs is working?
Not sure. I only have 2 DIMMs kits to test. Seem to work ok in both blue and black slots tho.
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 110: Gb
Gigabit or GigaByte?
Byte
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... PS38, Line 18: : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4"
not sure if those are needed, the board doesn't seem to use displayport
Let's test it.... Hmmm... not needed, apparently. VGA/DVI-D/HDMI seem to work ok without that.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#42).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,203 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/42
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#43).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,203 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/43
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 43: Code-Review+1
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#44).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/44
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#45).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- PS/2 - Audio - S3 Suspend to RAM - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME SSD boot (Tianocore) - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots(16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI working)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/45
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#46).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore + SeaBIOS - PS/2 - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME (Tianocore) - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU tested in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI working)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/46
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#47).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore + SeaBIOS boot - PS/2 - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU tested in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI working)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/47
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#48).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore + SeaBIOS boot - PS/2 - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU tested in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI tested)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/48
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#49).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU tested in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI tested)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/49
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#50).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,202 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/50
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#51).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,203 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/51
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 51: Code-Review+1
Ok, I consider this done and rdy for merge. I can't do anything much more with my limited gear and skill. Thanks for all your comments!
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 51: Code-Review+1
(1 comment)
Looks very good!
If you haven't done so, I would suggest testing with four memory modules. Even if you don't have four matched sticks, you could put them in pairs. If the mainboard slots are in order, that would mean installing a matched pair on the blue slots, and another matched pair on the black slots.
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 110: Gb
Byte
Ack. the case of the 'b' letter distinguishes between bits and bytes. 'Gb' stands for Gigabit, where 'GB' stands for Gigabyte.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#52).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,208 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/52
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#53).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Up-next: Test some internal headers and COM console. Question: Any idea how to fix the ACPI_BIOS_ERROR in Windows when using a PCIe GPU?
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 21 files changed, 1,208 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/53
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 53:
(1 comment)
Patch Set 51: Code-Review+1
(1 comment)
Looks very good!
If you haven't done so, I would suggest testing with four memory modules. Even if you don't have four matched sticks, you could put them in pairs. If the mainboard slots are in order, that would mean installing a matched pair on the blue slots, and another matched pair on the black slots.
A friend lent me a 4x4GB 1333 kit and works perfectly! Added it to the doc. I'm trying to fix the COM port on board and trying to figure our some internal headers I'm not sure what they are used for. Marking patch as WIP again.
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 110: Gb
Ack. the case of the 'b' letter distinguishes between bits and bytes. […]
Done
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 61: Code-Review+1
(2 comments)
Thanks for all your help and comments. I can't do much more with this board. I think it's ready for merge.
https://review.coreboot.org/#/c/33328/59/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/59/Documentation/mainboard/asus/p8z77-... PS59, Line 78: .
I'm not sure if it's better to end the lists' elements with a period or not. […]
have sense, indeed.
https://review.coreboot.org/#/c/33328/59/Documentation/mainboard/asus/p8z77-... PS59, Line 123: 6
Six?
Yep, it's a 6-channel kit really... but I just used 4 of the matched DIMMs. Works perfect for both native raminit and MRC.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 61:
(2 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 28: ![](p8z77-m_pro.jpg) do you have the copyright on the picture provided?
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 34: An external programmer is required period is missing
please recommend an external flashing method as described in https://doc.coreboot.org/flash_tutorial/index.html
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#62).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- M 3rdparty/blobs A 3rdparty/intel-microcode A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 24 files changed, 1,214 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/62
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 62: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 28: ![](p8z77-m_pro.jpg)
do you have the copyright on the picture provided?
Now yes. I just took a photo with my phone.
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 34: An external programmer is required
period is missing […]
About the period, our whole policy for the text file was not to use periods at the end of the paragraphs. So, for consistency, we won't add that period.
We added a mention to an external flash method as you suggested (CH341a+flashrom).
thx!
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#63).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- D 3rdparty/blobs A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 23 files changed, 1,212 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/63
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 63:
(3 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 28: ![](p8z77-m_pro.jpg)
Now yes. I just took a photo with my phone.
Great! Thanks!
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 34: An external programmer is required
About the period, our whole policy for the text file was not to use periods at the end of the paragr […]
No idea where that policy comes from. In general you add a period if it's a complete sentence. Thus on bullet list items you won't add it.
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... PS62, Line 34: An external programmer is required. You can just extract the SPI mentioning programmers or flashrom commands is not helpful. Those should go into https://doc.coreboot.org/flash_tutorial/index.html.
Just mention that you have to flash standalone, as flashing in-circuit doesn't work.
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#64).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- D 3rdparty/blobs A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 23 files changed, 1,212 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/64
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#65).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- D 3rdparty/blobs A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 23 files changed, 1,211 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/65
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#66).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- D 3rdparty/blobs A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 23 files changed, 1,211 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/66
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#67).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 22 files changed, 1,211 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/67
Vlado Cibic has removed HAOUAS Elyes from this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Removed reviewer HAOUAS Elyes.
Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 67: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 34: An external programmer is required
No idea where that policy comes from. […]
Done
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... PS62, Line 34: An external programmer is required. You can just extract the SPI
mentioning programmers or flashrom commands is not helpful. Those should go into https://doc. […]
Done
Vlado Cibic has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Removed reviewer Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 67: Code-Review+1
(2 comments)
I can see serial port is no longer untested, so it must be tested. But does it work or not?
https://review.coreboot.org/#/c/33328/59/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/59/Documentation/mainboard/asus/p8z77-... PS59, Line 123: 6
Yep, it's a 6-channel kit really... but I just used 4 of the matched DIMMs. […]
Ack
https://review.coreboot.org/#/c/33328/67/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/67/Documentation/mainboard/asus/p8z77-... PS67, Line 34: An external programmer is required. You must flash standalone, : flashing in-circuit doesn't work. I would mention that the flash chip is socketed, so it's easy to remove and reflash. That would get past the "Internal programming" section, though.
Hello Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33328
to look at the new patch set (#68).
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 22 files changed, 1,212 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33328/68
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 68: Code-Review+2
Looks good to me.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 68: Code-Review+2
Matt DeVillier has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
Add support for ASUS P8Z77-M PRO desktop mainboard
Working:
- Tianocore and SeaBIOS boot - PS/2 keyboard and mouse - Audio - S3 Suspend, shutdown and reboot - USB2 / USB3 - Gigabit Ethernet - SATA3, SATA2 and eSATA - NVME - CPU Temp sensors - TPM - Native raminit and also MRC - PCIe GPU in all PCIe slots (16x/8x/4x) (linux) - Integrated graphics with both libgfxinit and Intel Video OpROM (all connectors VGA/DVI-D/HDMI)
Signed-off-by: Vlado Cibic vladocb@protonmail.com Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/33328 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A Documentation/mainboard/asus/p8z77-m_pro.jpg A Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/index.md M MAINTAINERS A src/mainboard/asus/p8z77-m_pro/Kconfig A src/mainboard/asus/p8z77-m_pro/Kconfig.name A src/mainboard/asus/p8z77-m_pro/Makefile.inc A src/mainboard/asus/p8z77-m_pro/acpi/ec.asl A src/mainboard/asus/p8z77-m_pro/acpi/platform.asl A src/mainboard/asus/p8z77-m_pro/acpi/superio.asl A src/mainboard/asus/p8z77-m_pro/acpi_tables.c A src/mainboard/asus/p8z77-m_pro/board_info.txt A src/mainboard/asus/p8z77-m_pro/cmos.default A src/mainboard/asus/p8z77-m_pro/cmos.layout A src/mainboard/asus/p8z77-m_pro/data.vbt A src/mainboard/asus/p8z77-m_pro/devicetree.cb A src/mainboard/asus/p8z77-m_pro/dsdt.asl A src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads A src/mainboard/asus/p8z77-m_pro/gpio.c A src/mainboard/asus/p8z77-m_pro/hda_verb.c A src/mainboard/asus/p8z77-m_pro/mainboard.c A src/mainboard/asus/p8z77-m_pro/romstage.c 22 files changed, 1,212 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/asus/p8z77-m_pro.jpg b/Documentation/mainboard/asus/p8z77-m_pro.jpg new file mode 100644 index 0000000..bc6ef28 --- /dev/null +++ b/Documentation/mainboard/asus/p8z77-m_pro.jpg Binary files differ diff --git a/Documentation/mainboard/asus/p8z77-m_pro.md b/Documentation/mainboard/asus/p8z77-m_pro.md new file mode 100644 index 0000000..7c84149 --- /dev/null +++ b/Documentation/mainboard/asus/p8z77-m_pro.md @@ -0,0 +1,168 @@ +# ASUS P8Z77-M Pro + +This page describes how to run coreboot on the [ASUS P8Z77-M Pro] + +## Flashing coreboot + +```eval_rst ++---------------------+----------------+ +| Type | Value | ++=====================+================+ +| Socketed flash | yes | ++---------------------+----------------+ +| Model | W25Q64FVA1Q | ++---------------------+----------------+ +| Size | 8 MiB | ++---------------------+----------------+ +| Package | DIP-8 | ++---------------------+----------------+ +| Write protection | yes | ++---------------------+----------------+ +| Dual BIOS feature | no | ++---------------------+----------------+ +| Internal flashing | yes | ++---------------------+----------------+ +``` + +The flash IC is located right next to one of the SATA ports: +![](p8z77-m_pro.jpg) + +### Internal programming + +The main SPI flash cannot be written because Asus disables BIOSWE and +enables BLE/SMM_BWP flags in BIOS_CNTL for their latest bioses. +An external programmer is required. You must flash standalone, +flashing in-circuit doesn't work. The flash chip is socketed, so it's +easy to remove and reflash. + +## Working + +- PS/2 keyboard with SeaBIOS & Tianocore (in Mint 18.3/19.1) + +- Rear/front headphones connector audio & mic + +- S3 Suspend to RAM (tested with OS installed in a HDD/SSD and also with a + Mint 18.3/19.1 LiveUSB pendrive connected to USB3/USB2), but please + see [Known issues] + +- USB2 on rear (tested mouse/keyboard plugged there. Also, booting with + a Mint 18./19.1 LiveUSB works ok) + +- USB3 (Z77's and Asmedia's works, but please see [Known issues]) + +- Gigabit Ethernet (RTL8111F) + +- SATA3, SATA2 and eSATA (tested on all ports, hot-swap and TCG OPAL working) + (Blue SATA2) (Blue SATA2) (White SATA3) (Red eSATA SATA3 rear) + port 3 port 5 port 1 port 8 + port 4 port 6 port 2 port 7 + +- NVME SSD boot on PCIe-x16/x8/4x slot using Tianocore + (tested with M.2-to-PCIe adapter and a M.2 Samsung EVO 970 SSD) + +- CPU Temp sensors (tested PSensor on linux + HWINFO64 on Win10) + +- TPM on TPM-header (tested tpm-tools with Asus TPM 1.2 Infineon SLB9635TT12) + +- Native raminit and also MRC.bin(systemagent-r6.bin) memory initialization + (please see [Native raminit compatibility] and [MRC memory compatibility]) + +- Integrated graphics with both libgfxinit and the Intel Video BIOS OpROM + (VGA/DVI-D/HDMI tested and working) + +- 1x PCIe GPU in PCIe-16x/8x/4x slots (tested using Zotac GeForce GTX + 750Ti and FirePro W5100 under Mint 18.3/19.1) + +## Known issues + +- The rear's USB3s on bottom (closest to the PCB) have problems booting or + being used before the OS loads. For better compatibility, please use + the Z77's ones above the Ethernet connector or the Asmedia's top one + +- After S3 suspend, some USB3 connectors on rear seem not to work + +- At the moment, the power led does not blink when entering S3 state + +- Currently, we have not setup the SuperIO's Hardware Monitor (HWM), + so only the CPU sensors are reported + +- If you use the MRC.bin, the NVRAM variable gfx_uma_size may be ignored + as IGP's UMA could be reconfigured by the blob + +- Using TianoCore + a PCIe GPU under Windows crashes with an + ACPI_BIOS_ERROR fatal code, not sure why. Using just the IGP + works perfectly + +- Under Windows 10, if you experiment problems with PS/2 devices, change + HKLM\SYSTEM\CurrentControlSet\Services\i8042prt->Start from '3' to '1' + +## Untested + +- EHCI debugging +- S/PDIF audio +- Wake-on-LAN +- Serial port + +## Not working + +- PS/2 keyboard in Win10 using Tianocore (please see [Known issues]) +- PS/2 mouse using Tianocore +- PCIe graphics card on Windows and Tianocore (throws critical ACPI_BIOS_ERROR) + +## Native raminit compatibility + +- GSkill F3-2133C10D-16GAB(XMP,1.60v) 2x8GB kit works at 1333Mhz instead + of XMP 2133Mhz + +- Team Xtreem TXD38G2133HC9NDC01(XMP,1.50v) 2x4GB kit works at 1600Mhz + instead of XMP 2133Mhz + +- Kingston KVR1066D3N7K2/4G(JEDEC,1.50v) 2x4GB kit works at 1066Mhz + but the board only detects half its RAM, because those DIMMs have + Double Sided(DS) chips and seems only Single Sided(SS) ones are + fully detected + +- GSkill F3-10666CL9T2-24GBRL(JEDEC,1.50v) 6x4GB kit (4 DIMMs used) + works perfectly at full speed (1333Mhz) + +## MRC memory compatibility + +- GSkill F3-2133C10D-16GAB(XMP,1.60v) 2x8GB kit works at 1333Mhz + instead of XMP 2133Mhz + +- Team Xtreem TXD38G2133HC9NDC01(XMP,1.50v) 2x4GB kit works at + 1600Mhz instead of XMP 2133Mhz + +- Kingston KVR1066D3N7K2/4G(JEDEC,1.50v) 2x4GB kit works at 1066Mhz + but the board only detects half its RAM, as those DIMMs have + Double Sided(DS) chips and seems only Single Sided(SS) ones are + fully detected + +- GSkill F3-10666CL9T2-24GBRL(JEDEC,1.50v) 6x4GB kit (4 DIMMs used) + works perfectly at full speed (1333Mhz) + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | ++------------------+--------------------------------------------------+ +| Southbridge | bd82x6x | ++------------------+--------------------------------------------------+ +| CPU | model_206ax | ++------------------+--------------------------------------------------+ +| Super I/O | Nuvoton NCT6779D | ++------------------+--------------------------------------------------+ +| EC | None | ++------------------+--------------------------------------------------+ +| Coprocessor | Intel Management Engine | ++------------------+--------------------------------------------------+ +``` + +## Extra resources + +- [Flash chip datasheet][W25Q64FVA1Q] + +[ASUS P8Z88-M Pro]: https://www.asus.com/Motherboards/P8Z77M_PRO/ +[W25Q64FVA1Q]: https://www.winbond.com/resource-files/w25q64fv%20revs%2007182017.pdf +[flashrom]: https://flashrom.org/Flashrom diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 77e84ef..14c62ed 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -7,6 +7,7 @@ - [F2A85-M](asus/f2a85-m.md) - [P8H61-M LX](asus/p8h61-m_lx.md) - [P8H61-M Pro](asus/p8h61-m_pro.md) +- [P8Z77-M Pro](asus/p8z77-m_pro.md)
## ASRock
diff --git a/MAINTAINERS b/MAINTAINERS index e7780a8..83ba523 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -364,6 +364,11 @@ S: Maintained F: src/mainboard/asus/p8h61-m_pro/
+ASUS P8Z77-M PRO MAINBOARD +M: Vlado Cibic vladocb@protonmail.com +S: Maintained +F: src/mainboard/asus/p8z77-m_pro/ + PC ENGINES ALL MAINBOARDS M: Piotr Król piotr.krol@3mdeb.com M: Michał Żygowski michal.zygowski@3mdeb.com diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig b/src/mainboard/asus/p8z77-m_pro/Kconfig new file mode 100644 index 0000000..8d29a9b --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Kconfig @@ -0,0 +1,48 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +if BOARD_ASUS_P8Z77_M_PRO + +config BOARD_SPECIFIC_OPTIONS + def_bool y + select BOARD_ROMSIZE_KB_8192 + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_INT15 + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT + select MAINBOARD_HAS_LIBGFXINIT + select INTEL_GMA_HAVE_VBT + select SUPERIO_NUVOTON_NCT6779D + select DRIVERS_ASMEDIA_ASPM_BLACKLIST # for ASM1061 eSATA + +config MAINBOARD_DIR + string + default "asus/p8z77-m_pro" + +config MAINBOARD_PART_NUMBER + string + default "P8Z77-M PRO" + +config MAX_CPUS + int + default 8 + +endif # BOARD_ASUS_P8Z77_M_PRO diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig.name b/src/mainboard/asus/p8z77-m_pro/Kconfig.name new file mode 100644 index 0000000..c492094 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Kconfig.name @@ -0,0 +1,17 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +config BOARD_ASUS_P8Z77_M_PRO + bool "P8Z77-M PRO" diff --git a/src/mainboard/asus/p8z77-m_pro/Makefile.inc b/src/mainboard/asus/p8z77-m_pro/Makefile.inc new file mode 100644 index 0000000..0cc398a --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/Makefile.inc @@ -0,0 +1,19 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software: you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation, either version 2 of the License, or +## (at your option) any later version. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +romstage-y += gpio.c + +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl b/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl new file mode 100644 index 0000000..8b13789 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl @@ -0,0 +1 @@ + diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl new file mode 100644 index 0000000..3a69621 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl @@ -0,0 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Method(_WAK,1) +{ + Return(Package(){0,0}) +} + +Method(_PTS,1) +{ +} diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl b/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl new file mode 100644 index 0000000..7f1d04c --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl @@ -0,0 +1,17 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <drivers/pc80/pc/ps2_controller.asl> diff --git a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c new file mode 100644 index 0000000..2592c19 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c @@ -0,0 +1,35 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/bd82x6x/nvs.h> +#include <option.h> + +void acpi_create_gnvs(global_nvs_t *gnvs) +{ + /* Turn off power for USB ports in S3 by default */ + gnvs->s3u0 = 0; + gnvs->s3u1 = 0; + + /* Turn off power for USB ports in S5 by default */ + gnvs->s5u0 = 0; + gnvs->s5u1 = 0; + + /* critical temp that will shutdown the pc == 95C degrees */ + gnvs->tcrt = 95; + + /* temp to start throttling the cpu == 85C */ + gnvs->tpsv = 85; +} diff --git a/src/mainboard/asus/p8z77-m_pro/board_info.txt b/src/mainboard/asus/p8z77-m_pro/board_info.txt new file mode 100644 index 0000000..66e6f0d --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/board_info.txt @@ -0,0 +1,7 @@ +Category: desktop +Board URL: https://www.asus.com/Motherboards/P8Z77M_PRO/ +ROM package: DIP-8 +ROM protocol: SPI +ROM socketed: y +Flashrom support: y +Release year: 2013 diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.default b/src/mainboard/asus/p8z77-m_pro/cmos.default new file mode 100644 index 0000000..725ab98 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/cmos.default @@ -0,0 +1,24 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +boot_option=Fallback +debug_level=Debug +gfx_uma_size=224M +nmi=Enable +sata_mode=AHCI +#usb3_xxxx options are only used with MRC blob, ignored else +usb3_mode=Enable +usb3_drv=Enable +usb3_streams=Enable diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.layout b/src/mainboard/asus/p8z77-m_pro/cmos.layout new file mode 100644 index 0000000..da29d1c --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/cmos.layout @@ -0,0 +1,185 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +# ----------------------------------------------------------------- +entries + +# ----------------------------------------------------------------- +# Status Register A +# ----------------------------------------------------------------- +# Status Register B +# ----------------------------------------------------------------- +# Status Register C +#96 4 r 0 status_c_rsvd +#100 1 r 0 uf_flag +#101 1 r 0 af_flag +#102 1 r 0 pf_flag +#103 1 r 0 irqf_flag +# ----------------------------------------------------------------- +# Status Register D +#104 7 r 0 status_d_rsvd +#111 1 r 0 valid_cmos_ram +# ----------------------------------------------------------------- +# Diagnostic Status Register +#112 8 r 0 diag_rsvd1 + +# ----------------------------------------------------------------- +0 120 r 0 reserved_memory +#120 264 r 0 unused + +# ----------------------------------------------------------------- +# RTC_BOOT_BYTE (coreboot hardcoded) +384 1 e 3 boot_option +388 4 h 0 reboot_counter + +# ----------------------------------------------------------------- +# coreboot config options: console +#392 3 r 0 unused +395 4 e 4 debug_level +#399 1 r 0 unused +#400 8 r 0 reserved for century byte + +# ----------------------------------------------------------------- +# coreboot config options: southbridge + +# Non Maskable Interrupt(NMI) support, which is an interrupt that may +# occur on a RAM or unrecoverable error. +408 1 e 1 nmi + +409 2 e 5 power_on_after_fail +411 1 e 6 sata_mode + +# ----------------------------------------------------------------- +# coreboot config options: northbridge + +# gfx_uma_size +# Quantity of shared video memory the IGP can use +# +416 5 e 7 gfx_uma_size + +# ----------------------------------------------------------------- +# coreboot config options: usb3 + +# usb3_mode +# Controls how the motherboard's USB3 ports act at boot time +421 2 e 8 usb3_mode + +# usb3_drv +# Load (or not) pre-OS xHCI USB3 bios driver +# +423 1 e 1 usb3_drv + +# usb3_streams +# Streams can provide more speed (as they can use 64Kb packets), +# but they might cause incompatibilities with some devices. +# +424 1 e 1 usb3_streams + +# ----------------------------------------------------------------- +# Sandy/Ivy Bridge MRC Scrambler Seed values +# note: MUST NOT be covered by checksum! +464 32 r 0 mrc_scrambler_seed +496 32 r 0 mrc_scrambler_seed_s3 +528 16 r 0 mrc_scrambler_seed_chk + +# ----------------------------------------------------------------- +# coreboot config options: check sums +544 16 h 0 check_sum + +# ----------------------------------------------------------------- + +enumerations +#ID value text + +# Generic on/off enum +1 0 Disable +1 1 Enable + +# boot_option +3 0 Fallback +3 1 Normal + +# debug_level +4 0 Emergency +4 1 Alert +4 2 Critical +4 3 Error +4 4 Warning +4 5 Notice +4 6 Info +4 7 Debug +4 8 Spew + +# power_on_after_fail +5 0 Disable +5 1 Enable +5 2 Keep + +# sata_mode +6 0 AHCI +6 1 Compatible + +# gfx_uma_size (Intel IGP Video RAM size) +7 0 32M +7 1 64M +7 2 96M +7 3 128M +7 4 160M +7 5 192M +7 6 224M +7 7 256M +7 8 288M +7 9 320M +7 10 352M +7 11 384M +7 12 416M +7 13 448M +7 14 480M +7 15 512M +7 16 544M +7 17 576M +7 18 608M +7 19 640M +7 20 672M +7 21 704M +7 22 736M +7 23 768M +7 24 800M +7 25 832M +7 26 864M +7 27 896M +7 28 928M +7 29 960M +7 30 992M + +# usb3_mode +# Disable = Use the port always as USB 2.0 for compatibility +# Enable = Use the port always as USB 3.0 for speed +# Auto = Initialize the port as USB 2.0, until the OS loads +# xHCI USB 3.0 driver +# SmartAuto = Same as Auto but, if the OS loads the xHCI USB 3.0 driver +# and the computer is reset, keep the USB 3.0 mode. +# +8 0 Disable +8 1 Enable +8 2 Auto +8 3 SmartAuto + +# ----------------------------------------------------------------- +# <startBit[must be byte-aligned]> <endBit[must be byte aligned]> +# <bit where to start storing checksum[must be 16bits-aligned]> +checksums + +checksum 392 431 544 diff --git a/src/mainboard/asus/p8z77-m_pro/data.vbt b/src/mainboard/asus/p8z77-m_pro/data.vbt new file mode 100644 index 0000000..34679b3 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb new file mode 100644 index 0000000..4f5e5bf --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -0,0 +1,109 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" + register "gfx.ndid" = "3" + device cpu_cluster 0x0 on + chip cpu/intel/model_206ax + register "c1_acpower" = "1" + register "c1_battery" = "1" + register "c2_acpower" = "3" + register "c2_battery" = "3" + register "c3_acpower" = "5" + register "c3_battery" = "5" + device lapic 0x0 on end + device lapic 0xacac off end + end + end + device domain 0x0 on + subsystemid 0x1043 0x84ca inherit + device pci 00.0 on end # Host bridge + device pci 01.0 on end # PCIe Bridge for discrete graphics + device pci 02.0 on end # Internal graphics VGA controller + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH + register "c2_latency" = "0x0065" + register "gen1_dec" = "0x000c0291" + register "gen4_dec" = "0x0000ff29" + register "pcie_port_coalesce" = "1" + register "sata_interface_speed_support" = "0x3" # 0x3=SATAIII + register "sata_port_map" = "0x3f" # Enable the six SATA ports + register "spi_lvscc" = "0x2005" + register "spi_uvscc" = "0x2005" + register "superspeed_capable_ports" = "0x0000000f" + register "xhci_overcurrent_mapping" = "0x00000c03" + register "xhci_switchable_ports" = "0x0000000f" # the 4 ports + device pci 14.0 on end # USB 3.0 Controller + device pci 16.0 on end # Management Engine Interface 1 + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT + device pci 19.0 off end # Intel Gigabit Ethernet + device pci 1a.0 on end # USB2 EHCI 2 + device pci 1b.0 on end # High Definition Audio controller + device pci 1c.0 on end # PCIe Root Port 1 PCIEX_16_3 + device pci 1c.1 on end # PCIe Root Port 6 RTL8111F + device pci 1c.2 off end # PCIe Port 3 unused + device pci 1c.3 off end # PCIe Port 4 unused + device pci 1c.4 off end # PCIe Port 5 unused + device pci 1c.5 on end # PCIe Root Port 7 ASM1042 USB3 + device pci 1c.6 on end # PCIe Root Port 8 ASM1061 eSATA + device pci 1c.7 off end # PCIe Port 8 unused + device pci 1d.0 on end # USB2 EHCI 1 + device pci 1e.0 off end # PCI bridge + device pci 1f.0 on # LPC bridge + chip superio/nuvoton/nct6779d + device pnp 2e.1 off end # Parallel + device pnp 2e.2 off end # UART A + device pnp 2e.3 on # UART B, IR + io 0x60 = 0x2f8 # COM2 address + end + device pnp 2e.5 on # PS2 KBC + io 0x60 = 0x0060 # KBC1 base + io 0x62 = 0x0064 # KBC2 base + irq 0x70 = 1 # Keyboard IRQ + irq 0x72 = 12 # Mouse IRQ + + # KBC 12Mhz/A20 speed/sw KBRST + drq 0xf0 = 0x82 + end + device pnp 2e.6 off end # CIR + device pnp 2e.7 on end # GPIOs 6-8 + device pnp 2e.8 off end # WDT1 GPIO 0-1 + device pnp 2e.9 off end # GPIO 1-8 + device pnp 2e.a on # ACPI + drq 0xe4 = 0x10 # Enable 3VSBS to power RAM on S3 + drq 0xe7 = 0x10 # 0.5s S3 delay for compatibility + end + device pnp 2e.b off end # HWM, LED + device pnp 2e.d off end # WDT1 + device pnp 2e.e off end # CIR wake-up + device pnp 2e.f on # GPIO PP/OD + drq 0xe6 = 0x7f # GP7 PP + end + device pnp 2e.14 on end # Port 80 UART + device pnp 2e.16 off end # Deep sleep + end + chip drivers/pc80/tpm + device pnp 4e.0 on end # TPM module + end + end + device pci 1f.2 on end # SATA Controller 1 + device pci 1f.3 on end # SMBus + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal + end + end +end diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl new file mode 100644 index 0000000..89ad30c --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -0,0 +1,43 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 + +#include <arch/acpi.h> +DefinitionBlock( + "dsdt.aml", + "DSDT", + 0x02, /* DSDT revision: ACPI 2.0 and up */ + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20141018 /* OEM revision */ +) +{ + #include "acpi/platform.asl" + #include "acpi/superio.asl" + #include <cpu/intel/common/acpi/cpu.asl> + #include <southbridge/intel/bd82x6x/acpi/platform.asl> + + #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> + #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + + Device (_SB.PCI0) + { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } +} diff --git a/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads b/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads new file mode 100644 index 0000000..f9dd430 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads @@ -0,0 +1,31 @@ +-- +-- This file is part of the coreboot project. +-- +-- Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com +-- +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation, either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (HDMI1, -- DVI-D port on rear + HDMI3, -- real HDMI port on rear + Analog, -- VGA port on rear + others => Disabled); + +end GMA.Mainboard; diff --git a/src/mainboard/asus/p8z77-m_pro/gpio.c b/src/mainboard/asus/p8z77-m_pro/gpio.c new file mode 100644 index 0000000..c884215 --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/gpio.c @@ -0,0 +1,198 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/common/gpio.h> + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_NATIVE, + .gpio3 = GPIO_MODE_NATIVE, + .gpio4 = GPIO_MODE_NATIVE, + .gpio5 = GPIO_MODE_NATIVE, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_NATIVE, + .gpio10 = GPIO_MODE_NATIVE, + .gpio11 = GPIO_MODE_NATIVE, + .gpio12 = GPIO_MODE_GPIO, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_NATIVE, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_NATIVE, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_GPIO, + .gpio22 = GPIO_MODE_NATIVE, + .gpio23 = GPIO_MODE_NATIVE, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_NATIVE, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_GPIO, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_OUTPUT, + .gpio12 = GPIO_DIR_OUTPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_OUTPUT, + .gpio16 = GPIO_DIR_INPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio21 = GPIO_DIR_INPUT, + .gpio24 = GPIO_DIR_OUTPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_OUTPUT, + .gpio29 = GPIO_DIR_OUTPUT, + .gpio31 = GPIO_DIR_OUTPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio8 = GPIO_LEVEL_HIGH, + .gpio12 = GPIO_LEVEL_LOW, + .gpio15 = GPIO_LEVEL_LOW, + .gpio24 = GPIO_LEVEL_LOW, + .gpio28 = GPIO_LEVEL_LOW, + .gpio29 = GPIO_LEVEL_HIGH, + .gpio31 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio1 = GPIO_INVERT, + .gpio13 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_GPIO, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_NATIVE, + .gpio36 = GPIO_MODE_NATIVE, + .gpio37 = GPIO_MODE_NATIVE, + .gpio38 = GPIO_MODE_NATIVE, + .gpio39 = GPIO_MODE_NATIVE, + .gpio40 = GPIO_MODE_NATIVE, + .gpio41 = GPIO_MODE_NATIVE, + .gpio42 = GPIO_MODE_NATIVE, + .gpio43 = GPIO_MODE_NATIVE, + .gpio44 = GPIO_MODE_NATIVE, + .gpio45 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_GPIO, + .gpio47 = GPIO_MODE_NATIVE, + .gpio48 = GPIO_MODE_NATIVE, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_NATIVE, + .gpio51 = GPIO_MODE_NATIVE, + .gpio52 = GPIO_MODE_NATIVE, + .gpio53 = GPIO_MODE_NATIVE, + .gpio54 = GPIO_MODE_NATIVE, + .gpio55 = GPIO_MODE_NATIVE, + .gpio56 = GPIO_MODE_NATIVE, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_NATIVE, + .gpio60 = GPIO_MODE_NATIVE, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio32 = GPIO_DIR_OUTPUT, + .gpio33 = GPIO_DIR_OUTPUT, + .gpio34 = GPIO_DIR_INPUT, + .gpio45 = GPIO_DIR_INPUT, + .gpio46 = GPIO_DIR_INPUT, + .gpio49 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_OUTPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio32 = GPIO_LEVEL_HIGH, + .gpio33 = GPIO_LEVEL_HIGH, + .gpio57 = GPIO_LEVEL_LOW, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_NATIVE, + .gpio65 = GPIO_MODE_NATIVE, + .gpio66 = GPIO_MODE_NATIVE, + .gpio67 = GPIO_MODE_NATIVE, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_NATIVE, + .gpio71 = GPIO_MODE_NATIVE, + .gpio72 = GPIO_MODE_GPIO, + .gpio73 = GPIO_MODE_NATIVE, + .gpio74 = GPIO_MODE_NATIVE, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio72 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/asus/p8z77-m_pro/hda_verb.c b/src/mainboard/asus/p8z77-m_pro/hda_verb.c new file mode 100644 index 0000000..4fd3fcc --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/hda_verb.c @@ -0,0 +1,57 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ + 0x10438436, /* Subsystem ID */ + + 0x0000000f, /* Number of 4 dword sets */ + /* Subsystem ID */ + AZALIA_SUBVENDOR(0x0, 0x10438436), + + AZALIA_PIN_CFG(0x0, 0x11, 0x99430140), + AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0), + AZALIA_PIN_CFG(0x0, 0x14, 0x01014010), + AZALIA_PIN_CFG(0x0, 0x15, 0x01011012), + AZALIA_PIN_CFG(0x0, 0x16, 0x01016011), + AZALIA_PIN_CFG(0x0, 0x17, 0x01012014), + AZALIA_PIN_CFG(0x0, 0x18, 0x01a19850), + AZALIA_PIN_CFG(0x0, 0x19, 0x02a19c60), + AZALIA_PIN_CFG(0x0, 0x1a, 0x0181305f), + AZALIA_PIN_CFG(0x0, 0x1b, 0x02214c20), + AZALIA_PIN_CFG(0x0, 0x1c, 0x411111f0), + AZALIA_PIN_CFG(0x0, 0x1d, 0x4005e601), + AZALIA_PIN_CFG(0x0, 0x1e, 0x01456130), + AZALIA_PIN_CFG(0x0, 0x1f, 0x411111f0), + 0x80862806, /* Codec Vendor / Device ID: Intel */ + 0x80860101, /* Subsystem ID */ + + 0x00000004, /* Number of 4 dword sets */ + /* Subsystem ID */ + AZALIA_SUBVENDOR(0x3, 0x80860101), + + AZALIA_PIN_CFG(0x3, 0x05, 0x58560010), + AZALIA_PIN_CFG(0x3, 0x06, 0x58560020), + AZALIA_PIN_CFG(0x3, 0x07, 0x18560030), +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/asus/p8z77-m_pro/mainboard.c b/src/mainboard/asus/p8z77-m_pro/mainboard.c new file mode 100644 index 0000000..6cb41cc --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/mainboard.c @@ -0,0 +1,30 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/device.h> +#include <drivers/intel/gma/int15.h> + +static void mainboard_enable(struct device *dev) +{ + install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_NONE, + GMA_INT15_PANEL_FIT_DEFAULT, + GMA_INT15_BOOT_DISPLAY_DEFAULT, + 0); +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable +}; diff --git a/src/mainboard/asus/p8z77-m_pro/romstage.c b/src/mainboard/asus/p8z77-m_pro/romstage.c new file mode 100644 index 0000000..b5593ec --- /dev/null +++ b/src/mainboard/asus/p8z77-m_pro/romstage.c @@ -0,0 +1,193 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Vlado Cibic vladocb@protonmail.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ +#include <device/pci_ops.h> +#include <device/pnp_ops.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <southbridge/intel/bd82x6x/pch.h> + +#include <superio/nuvoton/common/nuvoton.h> +#include <superio/nuvoton/nct6779d/nct6779d.h> + +#include <option.h> + +#include <northbridge/intel/sandybridge/raminit_native.h> +#include <northbridge/intel/sandybridge/raminit.h> +#include <northbridge/intel/sandybridge/pei_data.h> + +#define GLOBAL_DEV PNP_DEV(0x2e, 0) +#define SERIAL_DEV PNP_DEV(0x2e, NCT6779D_SP2) + +void pch_enable_lpc(void) +{ + pci_write_config16(PCH_LPC_DEV, LPC_EN, + CNF1_LPC_EN | CNF2_LPC_EN | + KBC_LPC_EN | COMB_LPC_EN); + + /* Set COMB/COM2 IO range to 2F8h-2FFh */ + pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x10); +} + +void mainboard_rcba_config(void) +{ +} + +const struct southbridge_usb_port mainboard_usb_ports[] = { + /* {enable, current, oc_pin} */ + { 1, 2, 0 }, /* Port 0: USB3 front internal header, top */ + { 1, 2, 0 }, /* Port 1: USB3 front internal header, bottom */ + { 1, 2, 1 }, /* Port 2: USB3 rear, ETH top */ + { 1, 2, 1 }, /* Port 3: USB3 rear, ETH bottom */ + { 1, 2, 2 }, /* Port 4: USB2 rear, PS2 top */ + { 1, 2, 2 }, /* Port 5: USB2 rear, PS2 bottom */ + { 1, 2, 3 }, /* Port 6: USB2 internal header USB78, top */ + { 1, 2, 3 }, /* Port 7: USB2 internal header USB78, bottom */ + { 1, 2, 4 }, /* Port 8: USB2 internal header USB910, top */ + { 1, 2, 4 }, /* Port 9: USB2 internal header USB910, bottom */ + { 1, 2, 6 }, /* Port 10: USB2 internal header USB1112, top */ + { 1, 2, 5 }, /* Port 11: USB2 internal header USB1112, bottom */ + { 0, 2, 5 }, /* Port 12: Unused. Asus propietary DEBUG_PORT ??? */ + { 0, 2, 6 } /* Port 13: Unused. Asus propietary DEBUG_PORT ??? */ +}; + +void mainboard_early_init(int s3resume) +{ +} + +void mainboard_config_superio(void) +{ + /* Setup COM/UART */ + nuvoton_pnp_enter_conf_state(GLOBAL_DEV); + + /* TODO / FIXME: Setup Multifuncion/SIO pins for COM */ + + pnp_set_logical_device(SERIAL_DEV); + nuvoton_pnp_exit_conf_state(GLOBAL_DEV); + nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); +} + +void mainboard_get_spd(spd_raw_data *spd, bool id_only) +{ + read_spd(&spd[0], 0x50, id_only); + read_spd(&spd[1], 0x51, id_only); + read_spd(&spd[2], 0x52, id_only); + read_spd(&spd[3], 0x53, id_only); +} + +int mainboard_should_reset_usb(int s3resume) +{ + return !s3resume; +} + +void mainboard_fill_pei_data(struct pei_data *pei_data) +{ + /* + * USB3 mode: + * 0 = Disable: work always as USB 2.0(ehci) + * 1 = Enable: work always as USB 3.0(xhci) + * 2 = Auto: work as USB2.0(ehci) until OS loads USB3 xhci driver + * 3 = Smart Auto : same than Auto, but if OS loads USB3 driver + * and reboots, it will keep the USB3.0 speed + */ + int usb3_mode = 1; + get_option(&usb3_mode, "usb3_mode"); + usb3_mode &= 0x3; /* ensure it's 0/1/2/3 only */ + + /* Load USB3 pre-OS xHCI driver */ + int usb3_drv = 1; + get_option(&usb3_drv, "usb3_drv"); + usb3_drv &= 0x1; /* ensure it's 0/1 only */ + + /* Use USB3 xHCI streams */ + int usb3_streams = 1; + get_option(&usb3_streams, "usb3_streams"); + usb3_streams &= 0x1; /* ensure it's 0/1 only */ + + struct pei_data pd = { + .pei_version = PEI_VERSION, + .mchbar = (uintptr_t)DEFAULT_MCHBAR, + .dmibar = (uintptr_t)DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = CONFIG_HPET_ADDRESS, + .rcba = (uintptr_t)DEFAULT_RCBABASE, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .thermalbase = 0xfed08000, + .system_type = 1, /* 0=Mobile, 1=Desktop/Server */ + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xa0, 0xa2, 0xa4, 0xa6 }, /* SMBus mul 2 */ + .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, + .ec_present = 0, /* Asus 2203 bios shows XUECA016, but no EC */ + .gbe_enable = 0, /* Board uses no Intel GbE but a RTL8111F */ + .dimm_channel0_disabled = 0, /* Both DIMM enabled */ + .dimm_channel1_disabled = 0, /* Both DIMM enabled */ + .max_ddr3_freq = 1600, /* 1333=Sandy; 1600=Ivy */ + .usb_port_config = { + /* {enabled, oc_pin, cable len 0x0080=<8inches/20cm} */ + { 1, 0, 0x0080 }, /* USB3 front internal header */ + { 1, 0, 0x0080 }, /* USB3 front internal header */ + { 1, 1, 0x0080 }, /* USB3 ETH top connector */ + { 1, 1, 0x0080 }, /* USB3 ETH botton connector */ + { 1, 2, 0x0080 }, /* USB2 PS2 top connector */ + { 1, 2, 0x0080 }, /* USB2 PS2 botton connector */ + { 1, 3, 0x0080 }, /* USB2 internal header (USB78) */ + { 1, 3, 0x0080 }, /* USB2 internal header (USB78) */ + { 1, 4, 0x0080 }, /* USB2 internal header (USB910) */ + { 1, 4, 0x0080 }, /* USB2 internal header (USB910) */ + { 1, 6, 0x0080 }, /* USB2 internal header (USB1112) */ + { 1, 5, 0x0080 }, /* USB2 internal header (USB1112) */ + { 0, 5, 0x0080 }, /* Unused. Asus DEBUG_PORT ??? */ + { 0, 6, 0x0080 } /* Unused. Asus DEBUG_PORT ??? */ + }, + .usb3 = { + /* 0=Disable; 1=Enable (start at USB3 speed) + * 2=Auto (start as USB2 speed until OS loads) + * 3=Smart Auto (like Auto but keep speed on reboot) + */ + usb3_mode, + /* 4 bit switch mask. 0=not switchable, 1=switchable + * Means once it's loaded the OS, it can swap ports + * from/to EHCI/xHCI. Z77 has four USB3 ports, so 0xf + */ + 0xf, + usb3_drv, /* 1=Load xHCI pre-OS drv */ + /* 0=Don't use xHCI streams for better compatibility + * 1=use xHCI streams for better speed + */ + usb3_streams + }, + /* ASUS P8Z77-M Pro manual says 1.35v DIMMs are supported */ + .ddr3lv_support = 1, + /* PCIe 3.0 support. As we use Ivy Bridge, let's enable it, + * but might cause some system inestability ! + */ + .pcie_init = 1, + /* Command Rate. 0=Auto; 1=1N; 2=2N. + * Leave it always at Auto for compatibility & stability + */ + .nmode = 0, + /* DDR refresh rate. 0=Auto based on DRAM's temperature; + * 1=Normal rate for speed; 2=Double rate for stability + */ + .ddr_refresh_rate_config = 0 + }; + + /* copy the data to output PEI */ + *pei_data = pd; +}