Attention is currently required from: Yu-Ping Wu.
Jakub Czapiga has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: lib/string: Add strncat() and strcat() functions
......................................................................
Patch Set 2:
(1 comment)
File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/83765/comment/45bf3cee_c1afb906?usp... :
PS2, Line 193: ret = strncat(dst, src, len - 1);
`len` is the size of `str` not `src`. This way the case where the count is smaller than src len is not checked. Same is the case for `test_strcat`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83765?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If02fce0eafb4f6fa01d8bab17d87a32360f4ac83
Gerrit-Change-Number: 83765
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 05 Aug 2024 07:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No