Attention is currently required from: Baieswara Reddy Sagili, Michał Kopeć, Michał Żygowski, Subrata Banik, Sumeet Pawnikar, Tarun Tuli.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72998?usp=email )
Change subject: soc/intel/alderlake/vr_config.c: Fix GT domain TDC current
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/72998/comment/fcacf825_1b6bee72 :
PS2, Line 252: { PCI_DID_INTEL_ADL_S_ID_1, 150, VR_CFG_ALL_DOMAINS_TDC_CURRENT(132, 22) },
I have only found discrepancies in the GT TDC. IA TDCs were correct.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72998?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6851d322fc9354d019a76503c3d35b5e6eca48b
Gerrit-Change-Number: 72998
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.corp-partner.google.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 12:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment