Change in coreboot[master]: mb/google/skyrim: Configure SD card reader power sequence - coreboot-gerrit

21 Apr 2022


      Attention is currently required from: Raul Rangel, Ian Feng, Karthik Ramasubramanian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 )
Change subject: mb/google/skyrim: Configure SD card reader power sequence
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/63739/comment/d3ab0d96_4199ca07 
PS5, Line 201: 	PAD_GPO(GPIO_27, HIGH),
ramstage set high is enough, do we need set high here?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735
Gerrit-Change-Number: 63739
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 08:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment