Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 31:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 11: Make M.2 port configurable (SATA <>
have a look at intel flex i/o. […]
It usually boils down to configuring a GPIO properly
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/romstage.c:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 22: 0 Any reason to disable ECT?
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 35: subsystemid 0x1558 0x1403 you can inherit that