Attention is currently required from: Lance Zhao, Tim Van Patten. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63558 )
Change subject: drivers/usb/acpi: acpi_power_res_params: Add use_gpio_for_status ......................................................................
Patch Set 2:
(3 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/63558/comment/cd67ab8f_48972f91 PS2, Line 608: bool active not required
https://review.coreboot.org/c/coreboot/+/63558/comment/a4f404a9_6969e43f PS2, Line 623: f (active) : acpigen_emit_byte(LNOT_OP); acpigen_get_tx_gpio() will already return "1" for the active state, regardless of polarity (i.e., the function already takes care of the pin's polarity, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
https://review.coreboot.org/c/coreboot/+/63558/comment/ccd393f3_8cfc6f28 PS2, Line 703: /* Check if the device is already enabled before enabling it again. : This allows for skipping the sleep if it's also requested. */ See https://doc.coreboot.org/contributing/coding_style.html?highlight=Commenting about style for multi-line comments