Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, Paul Menzel, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55078 )
Change subject: qualcomm/sc7280: gpio: Support eGPIO scheme
......................................................................
Patch Set 12:
(1 comment)
File src/soc/qualcomm/sc7280/sc7280_egpio.c:
https://review.coreboot.org/c/coreboot/+/55078/comment/764fdde7_26c2e693
PS3, Line 56: setbits32(®s->cfg, BIT(EGPIO_CFG_EN));
[…]
Sorry, I still don't understand. The code you wrote here runs on the CPU, right? Just as kernel code would. So why can't the kernel run this code during GPIO/pinmux probe instead? Are the EGPIO_CFG registers you're writing here protected in some way so that they would become inaccessible later in the boot flow, or at a lower exception level?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c54a14c50fb7b5921d1961d2de83098ed2d4358
Gerrit-Change-Number: 55078
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
tdas@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 21:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Taniya Das
tdas@codeaurora.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment