Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34126 )
Change subject: arch/x86: Replace some uses of SMM_TSEG ......................................................................
arch/x86: Replace some uses of SMM_TSEG
No reason why the files could not be used with ASEG. Attempts to use malloc() from ASEG would still fail, though, due the lack of heap.
Change-Id: Idf470ae84eb34c442e833925510b08d5314e7638 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/console/Makefile.inc M src/lib/Makefile.inc 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34126/1
diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc index 4f0c2ef..3311849 100644 --- a/src/console/Makefile.inc +++ b/src/console/Makefile.inc @@ -8,8 +8,8 @@ endif
smm-$(CONFIG_DEBUG_SMI) += init.c console.c vtxprintf.c printk.c -smm-$(CONFIG_SMM_TSEG) += die.c -smm-$(CONFIG_SMM_TSEG) += post.c +smm-y += die.c +smm-y += post.c
verstage-y += init.c verstage-y += printk.c diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index f6d3f6d..f0738ee 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -117,7 +117,6 @@ ramstage-y += memchr.c ramstage-y += memcmp.c ramstage-y += malloc.c -smm-$(CONFIG_SMM_TSEG) += malloc.c ramstage-y += dimm_info_util.c ramstage-y += delay.c ramstage-y += fallback_boot.c @@ -190,6 +189,7 @@ ramstage-y += boot_device.c
smm-y += boot_device.c +smm-y += malloc.c smm-y += delay.c smm-y += fmap.c smm-y += cbfs.c memcmp.c
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34126 )
Change subject: arch/x86: Replace some uses of SMM_TSEG ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34126 )
Change subject: arch/x86: Replace some uses of SMM_TSEG ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34126 )
Change subject: arch/x86: Replace some uses of SMM_TSEG ......................................................................
arch/x86: Replace some uses of SMM_TSEG
No reason why the files could not be used with ASEG. Attempts to use malloc() from ASEG would still fail, though, due the lack of heap.
Change-Id: Idf470ae84eb34c442e833925510b08d5314e7638 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34126 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/console/Makefile.inc M src/lib/Makefile.inc 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc index 4f0c2ef..3311849 100644 --- a/src/console/Makefile.inc +++ b/src/console/Makefile.inc @@ -8,8 +8,8 @@ endif
smm-$(CONFIG_DEBUG_SMI) += init.c console.c vtxprintf.c printk.c -smm-$(CONFIG_SMM_TSEG) += die.c -smm-$(CONFIG_SMM_TSEG) += post.c +smm-y += die.c +smm-y += post.c
verstage-y += init.c verstage-y += printk.c diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index f6d3f6d..f0738ee 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -117,7 +117,6 @@ ramstage-y += memchr.c ramstage-y += memcmp.c ramstage-y += malloc.c -smm-$(CONFIG_SMM_TSEG) += malloc.c ramstage-y += dimm_info_util.c ramstage-y += delay.c ramstage-y += fallback_boot.c @@ -190,6 +189,7 @@ ramstage-y += boot_device.c
smm-y += boot_device.c +smm-y += malloc.c smm-y += delay.c smm-y += fmap.c smm-y += cbfs.c memcmp.c
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)