[M] Change in coreboot[master]: mb/siemens/mc_ehl4: Adjust GPIOs - coreboot-gerrit

21 Apr 2023


      Attention is currently required from: Mario Scheithauer, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 )
Change subject: mb/siemens/mc_ehl4: Adjust GPIOs
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c:
https://review.coreboot.org/c/coreboot/+/74628/comment/bfa64682_1f953f99 
PS1, Line 12: 	PAD_NC(GPP_B4, NONE),				/* Not connected */
            : 	PAD_NC(GPP_B9, NONE),				/* Not connected */
            : 	PAD_NC(GPP_B10, NONE),				/* Not connected */
Nit: Can the NCs be removed?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43
Gerrit-Change-Number: 74628
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jan Samek jan.samek@siemens.com
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 08:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment