Attention is currently required from: ChiaLing, Paul Menzel, Reka Norman, Ryan Lin, Subrata Banik, Zhuohao Lee.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75680?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75680/comment/4a082e12_3aca8c90 :
PS4, Line 56: void variant_update_power_limits(const struct cpu_power_limits *limits, size_t num_entries)
use common code as per this https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
Refer baseboard code https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/rex/va...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75680?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583c930379233322c41027805369f81d02000ee7
Gerrit-Change-Number: 75680
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 07:38:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment