Attention is currently required from: Malik Hsu, Tim Wawrzynczak, Paul Menzel.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56923/comment/39d320aa_72d86990
PS2, Line 7: config G2 touchscreen
suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/56923/comment/9f2c007e_c773deb2
PS2, Line 9: touchscreen spec
It was just a typo, using the incorrect polarity on the reset GPIO
Ack
https://review.coreboot.org/c/coreboot/+/56923/comment/c223a81b_3463b02e
PS2, Line 13: TEST=build coreboot and touchscreen works
not if the reset GPIO polarity was backwards 😊
Ack
Patchset:
PS3:
Thanks Tim.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 13 Aug 2021 01:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment