Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: arch/x86: Helper functions to get deterministic cache parameters
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55965/comment/3bf4da42_76fb2927
PS7, Line 20: cahce
cache
Patchset:
PS7:
Why bother with caching the results of this CPUID call?
Why not something like:
```
bool get_cpu_cache_info(uint8_t level, struct cpu_cache_info *info)
{
if (!info)
return false;
uint32_t leaf = cpu_get_cache_info_leaf();
if (!leaf)
return;
struct cpuid_result result = cpuid_ext(leaf, level);
info->type = cpu_get_cache_type(result);
info->level = cpu_get_cache_level(result);
info->.......
}
```
then the other functions are more like:
```
size_t cache_size(const struct cpu_cache_info *info)
{
return info->num_ways * info->physical_partitions *
info->line_size * info->num_sets;
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095
Gerrit-Change-Number: 55965
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 22:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment