Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ravindra, Nick Vaccaro, Sridhar Siricilla, Patrick Rudolph. Ravindra N has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60020 )
Change subject: soc/intel/common/cse: Update help text for CSE_OEMP_FILE ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60020/comment/38a7866a_4fc95f61 PS1, Line 10: Intel.The
Please add a space after the dot/period.
Ack
Patchset:
PS1:
How is `OEMP_FILE` used? […]
board specific config defined in the chromiumos-overlay to get the oem key binary from the private overlays folder and this binary will be stitched as a part of cse region. Which will authenticate the oem components.
Patchset:
PS2: Please review the changes
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/60020/comment/7ab45b6b_04890e2c PS1, Line 184: KM
As the whole string is short enough, maybe use the longer form *Key Manifest*.
Ack
https://review.coreboot.org/c/coreboot/+/60020/comment/d5e200e4_cce5961d PS1, Line 190: public
private?
yes with private key signed the manifest and public key used to authenticate the manifest.
https://review.coreboot.org/c/coreboot/+/60020/comment/2c56b4bb_58150f9e PS1, Line 191: asset_generation/signing/outputs
Is that a path? Maybe give an explicit example, what directory this file should live in.
oem km will be during the signing and located in the private-overlays:files/blobs/cse_inputs
https://review.coreboot.org/c/coreboot/+/60020/comment/85e11738_f8079d4d PS1, Line 190: to be : the part of
No *the*? to be part of
Ack
-
Ravindra N (Code Review)