Attention is currently required from: Martin Roth, Michael Niewöhner, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52809 )
Change subject: treewide: Kconfig: replace `def_bool n` by `bool`
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
If the type would be only given […]
That's how things are often done, but not necessarily. If we'd strongly separate
declaration and defaults it could be like this:
src/somewhere/option/is/used/Kconfig:
config SOMETHING
bool
src/mainboard/where/default/is/set/Kconfig:
if MAINBOARD_SOME_VENDOR_SOME_MODEL
config SOMETHING
default n
endif
src/somewhere/option/is/used/Kconfig:
config SOMETHING
default y
IIRC, Martin did this separation of declaration and global default
for options with a prompt some time ago. Options with a prompt have
a strong requirement for this: the first declaration decides where
the prompt is shown in the menu structure. It turned out there are
a few weaker arguments for this for all options, e.g. when it comes
to the automatically generated part of help texts and references to
other symbols within.
Now, this separation isn't very easy because of the dependency on
the include order of Kconfig files. One way would be to have an
optional `Kconfig.decl` everywhere and a separate `Kconfig` or
`Kconfig.def[ault]` or something like this. Then we'd have to in-
clude the former everywhere first, in opposite order.
That's just theory how it could work. I'm not saying let's do this.
Currently, my feelings are rather neutral about it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e89c66d18b7b3a5ac425eacea10df8c013814f
Gerrit-Change-Number: 52809
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 04 May 2021 12:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment