Change in coreboot[master]: sc7180: Add QUPv3 FW load & config - coreboot-gerrit

30 Mar 2020


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config
......................................................................
Patch Set 44:
(1 comment)
Please make sure you don't overlook the outstanding issue from Patch Set 40!
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... 
PS44, Line 21: 							unsigned int mode)
...
We added "mode" param back to be generic and portable in future.  […]
Okay, if we think that mainboards may need to individually select other modes I guess that's okay.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 44
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson dianders@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Satya Priya Kakitapalli c_skakit@qualcomm.corp-partner.google.com
Gerrit-CC: Stephen Boyd swboyd@chromium.org
Gerrit-CC: Taniya Das tdas@codeaurora.org
Gerrit-Comment-Date: Mon, 30 Mar 2020 22:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment