Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47993 )
Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... PS4, Line 60: !FSP_USE_REPO
Only the string changed, that means, FSP_FD_PATH gets hidden in menuconfig, when FSP_USE_REPO is sel […]
Makes sense.
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... PS4, Line 88: Use a combined FSP FD file instead of individual, split binaries.
Not completely correct. FSP_FULL_FD is a boolean. The file then needs to be set in FSP_FD_PATH. […]
Ack
-
Furquan Shaikh (Code Review)