Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62903/comment/992f1ee5_a94f525c PS3, Line 9: bouard
board
Done
https://review.coreboot.org/c/coreboot/+/62903/comment/08aa4262_abcacf57 PS3, Line 10: shematics
schematics
Done
https://review.coreboot.org/c/coreboot/+/62903/comment/03efcc20_5065263e PS3, Line 13: TEST=Builds
just a build test is likely not sufficient; at least i'd prefer to have it verified on hardware that […]
I don't have hardware, we could send it to the factory, or wait until Google receives hardware?
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/62903/comment/6459726c_ad027f77 PS3, Line 49: //.port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} // TODO: uncomment this when PSPP is working
the commented out lines can be dropped for now. […]
Ack
https://review.coreboot.org/c/coreboot/+/62903/comment/70ee4fb4_86d757fd PS3, Line 54: .start_logical_lane = 0,
the engine is unused, but the lanes overlap with the dxio descriptors before this one
Ack
-
Jon Murphy (Code Review)