Change in coreboot[master]: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to... - coreboot-gerrit

25 Apr 2022


      Attention is currently required from: Michał Żygowski, Elyes Haouas.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62378 )
Change subject: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/northbridge/amd/agesa/family15tn/northbridge.c:
https://review.coreboot.org/c/coreboot/+/62378/comment/903bb3ac_d4925153 
PS1, Line 716: 		if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) {
Wow, could this maybe be a bit less readable?  :-/
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62378
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8
Gerrit-Change-Number: 62378
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 24 Apr 2022 21:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment