Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )
Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/64035/comment/9f529515_1bc70150 PS1, Line 281: *current No need for a pointer, AFAICS.
https://review.coreboot.org/c/coreboot/+/64035/comment/6c28f7be_d62a546a PS1, Line 291: t->form_factor = 0x2; /* Unknown */ Shouldn't this be DIMM?
https://review.coreboot.org/c/coreboot/+/64035/comment/8d478b22_524824e5 PS1, Line 295: t->manufacturer = smbios_add_string(t->eos, "NO DIMM"); : t->serial_number = smbios_add_string(t->eos, "NO DIMM"); : t->asset_tag = smbios_add_string(t->eos, "NO DIMM"); : t->part_number = smbios_add_string(t->eos, "NO DIMM"); Why set these? Isn't that the job of the consuming application, i.e. interpret `size == 0` as this?