Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables ......................................................................
Patch Set 13: Code-Review-1
(3 comments)
The others look good
https://review.coreboot.org/#/c/29917/13/src/soc/intel/fsp_broadwell_de/roms... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/13/src/soc/intel/fsp_broadwell_de/roms... PS13, Line 118: breaks cbmem
https://review.coreboot.org/#/c/29917/13/src/soc/intel/quark/i2c.c File src/soc/intel/quark/i2c.c:
https://review.coreboot.org/#/c/29917/13/src/soc/intel/quark/i2c.c@a132 PS13, Line 132: that breaks the fifo cleaning code
https://review.coreboot.org/#/c/29917/13/src/southbridge/intel/fsp_rangeley/... File src/southbridge/intel/fsp_rangeley/romstage.c:
https://review.coreboot.org/#/c/29917/13/src/southbridge/intel/fsp_rangeley/... PS13, Line 121: that breaks cbmem