Attention is currently required from: Damien Zammit, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62808/comment/838d08cf_26f64536 PS1, Line 1: BOARD_HP_Z220_SERIES BOARD_HP_Z220_SERIES_COMMON
File src/mainboard/hp/z220_series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62808/comment/8acc8910_76a0504b PS1, Line 3: select BOARD_HP_Z220_SERIES Please do selects only in Kconfig and not in Kconfig.name. See mb/siemens/chili for example.
File src/mainboard/hp/z220_series/Makefile.inc:
PS1: Group the entries by stage:
bootblock-y ... bootblock-y ...
romstage-y ... romstage-y ...
-
Felix Singer (Code Review)