Change in coreboot[master]: src/acpi: Drop unneeded empty lines

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44603 )

Change subject: src/acpi: Drop unneeded empty lines
......................................................................

src/acpi: Drop unneeded empty lines

Change-Id: I561717c9ee3471462ee510f12c821cfe236b23be
Signed-off-by: Elyes HAOUAS 
---
M src/acpi/acpigen.c
M src/acpi/device.c
2 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/44603/1

diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c
index f218706..b76966b 100644
--- a/src/acpi/acpigen.c
+++ b/src/acpi/acpigen.c
@@ -284,7 +284,6 @@
    pathlen[0] = count;
 }

-
 void acpigen_emit_namestring(const char *namepath)
 {
    int dotcount = 0, i;
@@ -930,8 +929,6 @@
    acpigen_pop_len();
 }

-
-
 void acpigen_write_mem32fixed(int readwrite, u32 base, u32 size)
 {
    /*
@@ -1772,7 +1769,6 @@
    acpigen_pop_len();
 }

-
 /* Soc-implemented functions -- weak definitions. */
 int __weak acpigen_soc_read_rx_gpio(unsigned int gpio_num)
 {
diff --git a/src/acpi/device.c b/src/acpi/device.c
index 07e80f5..450427d 100644
--- a/src/acpi/device.c
+++ b/src/acpi/device.c
@@ -198,7 +198,6 @@
    return ACPI_STATUS_DEVICE_ALL_ON;
 }

-
 /* Write the unique _UID based on ACPI device path. */
 void acpi_device_write_uid(const struct device *dev)
 {

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44603 )

Change subject: src/acpi: Drop unneeded empty lines
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44603 )

Change subject: src/acpi: Drop unneeded empty lines
......................................................................

src/acpi: Drop unneeded empty lines

Change-Id: I561717c9ee3471462ee510f12c821cfe236b23be
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44603
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/acpi/acpigen.c
M src/acpi/device.c
2 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c
index a82a66e..44f9106 100644
--- a/src/acpi/acpigen.c
+++ b/src/acpi/acpigen.c
@@ -284,7 +284,6 @@
    pathlen[0] = count;
 }

-
 void acpigen_emit_namestring(const char *namepath)
 {
    int dotcount = 0, i;
@@ -930,8 +929,6 @@
    acpigen_pop_len();
 }

-
-
 void acpigen_write_mem32fixed(int readwrite, u32 base, u32 size)
 {
    /*
@@ -1779,7 +1776,6 @@
    acpigen_pop_len();
 }

-
 /* Soc-implemented functions -- weak definitions. */
 int __weak acpigen_soc_read_rx_gpio(unsigned int gpio_num)
 {
diff --git a/src/acpi/device.c b/src/acpi/device.c
index 07e80f5..450427d 100644
--- a/src/acpi/device.c
+++ b/src/acpi/device.c
@@ -198,7 +198,6 @@
    return ACPI_STATUS_DEVICE_ALL_ON;
 }

-
 /* Write the unique _UID based on ACPI device path. */
 void acpi_device_write_uid(const struct device *dev)
 {

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44603 )

Change subject: src/acpi: Drop unneeded empty lines
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/3/7
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16385
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16384
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16383
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16382
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16381
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/16387
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16386

Please note: This test is under development and might not be accurate at all!