build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 45:
(15 comments)
https://review.coreboot.org/#/c/29563/45/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/29563/45/src/include/memlayout.h@167 PS45, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/29563/45/src/include/memlayout.h@167 PS45, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi.h File src/security/tpm/tspi.h:
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi.h@52 PS45, Line 52: uint32_t tpm_extend_pcr(int pcr, const char *digest_type, uint8_t *digest, size_t digest_len, line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@34 PS45, Line 34: size_t tcpa_log_len = sizeof(struct tcpa_table) + MAX_TCPA_LOG_ENTRIES * sizeof(struct tcpa_entry); line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@51 PS45, Line 51: if (IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY) && !cbmem_possibly_online()) line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@53 PS45, Line 53: else if (IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY) && cbmem_possibly_online() && ENV_ROMSTAGE) { line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@93 PS45, Line 93: void tcpa_log_add_table_entry(const char *name, const uint32_t pcr, const char *digest_type, line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@126 PS45, Line 126: if (IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY) && ENV_CACHE_AS_RAM && IS_ENABLED(CONFIG_VBOOT_STARTS_IN_BOOTBLOCK)) { line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@154 PS45, Line 154: struct tcpa_entry *tce = &ram_log->entries[ram_log->num_entries++]; line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@155 PS45, Line 155: strncpy(tce->name, preram_log->entries[i].name, TCPA_PCR_HASH_NAME - 1); line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@158 PS45, Line 158: if (preram_log->entries[i].digest_length > TCPA_DIGEST_MAX_LENGTH) { line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@163 PS45, Line 163: strncpy(tce->digest_type, preram_log->entries[i].digest_type, TCPA_PCR_HASH_LEN - 1); line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@164 PS45, Line 164: tce->digest_length = MIN(preram_log->entries[i].digest_length, TCPA_DIGEST_MAX_LENGTH); line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/tpm/tspi/log.c@165 PS45, Line 165: memcpy(tce->digest, preram_log->entries[i].digest, tce->digest_length); line over 80 characters
https://review.coreboot.org/#/c/29563/45/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/29563/45/src/security/vboot/secdata_tpm.c@86 PS45, Line 86: return tpm_extend_pcr(pcr, "SHA256", buffer, size, TPM_PCR_GBB_HWID_NAME); line over 80 characters
-
build bot (Jenkins) (Code Review)