Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ......................................................................
Patch Set 2:
(24 comments)
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/60561274_66b0b6bf PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/41e5a023_1a47ed3e PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/6c719c63_8701b83a PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e605375d_6901a0ee PS2, Line 17: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/c6fc3fa9_9c1a32b1 PS2, Line 18: const struct device *codec = find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/37074891_e7414b19 PS2, Line 18: const struct device *codec = find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/d93a167a_92492d7e PS2, Line 19: struct drivers_i2c_generic_config *config; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/a50b8eb5_be27fa0c PS2, Line 20: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/c2122bae_6b448c9c PS2, Line 20: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e84f06a0_aeb9b590 PS2, Line 21: if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/028f860a_9711722b PS2, Line 22: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/de42bd21_e083872c PS2, Line 22: return; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/efe25583_131a98a1 PS2, Line 22: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/5dd640b5_98f7c882 PS2, Line 23: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/577fcad7_c6739bf3 PS2, Line 23: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/fa77ff14_98aa1fe7 PS2, Line 24: config = codec->chip_info; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/7ea357aa_a8c2a4e0 PS2, Line 25: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/64e37b45_0ce3109e PS2, Line 26: config->hid = "10EC5682"; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/628405d8_7b22ebbb PS2, Line 26: config->hid = "10EC5682"; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/4bab6a2e_b21fbddc PS2, Line 26: config->hid = "10EC5682"; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/f54d2f26_6eb3f8ff PS2, Line 27: else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/62d49af8_9e490db4 PS2, Line 28: config->hid = "RTL5682"; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/44b319a6_10f0ff6e PS2, Line 28: config->hid = "RTL5682"; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e5f85549_536b72ec PS2, Line 28: config->hid = "RTL5682"; please, no spaces at the start of a line