Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email )
Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85547/comment/072eda0c_c3ecbf9f?usp... :
PS3, Line 11: # EC memory map range is 0x900-0x9ff and indexed access is through 0x380
Updated, Can you confirm based on the range is the programmed value correct ? Thanks!
Acknowledged
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85547/comment/a4da5599_64db77c6?usp... :
PS6, Line 15: (0x00010001 | CONFIG(EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PO
I guess this will cause issue, `EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT` is a hex value
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85547?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6
Gerrit-Change-Number: 85547
Gerrit-PatchSet: 7
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 20 Dec 2024 12:56:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jayvik Desai
jayvik@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com