Change in coreboot[master]: soc/intel/common/block/cpu: Refactor LLC non-eviction mask calculation - coreboot-gerrit

9 Mar 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51251 )
Change subject: soc/intel/common/block/cpu: Refactor LLC non-eviction mask calculation
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/51251/comment/f134028c_85150f9a 
PS2, Line 418: back up the number of ways of LLC to protect from eviction
...
...
...
You are right on the logic but DCACHE_RAM_SIZE is too big i believe frim way size. […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcbd577c360a1ebc34cbd4770ef12aad82b4fc71
Gerrit-Change-Number: 51251
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 09 Mar 2021 09:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment