Change in coreboot[master]: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEV... - coreboot-gerrit

19 Nov 2021


      Attention is currently required from: Varshit B Pandya.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59260 )
Change subject: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59260/comment/5906034c_6ffb3b72 
PS3, Line 355: GPP_D16
Not for this change, but we need to improve this driver... two different power resources are both exposing GPP_D16, which could cause races or other undesirable power states 😞
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88ea1b87698c63e1bd69367ee857fba3f25c84ea
Gerrit-Change-Number: 59260
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Arec arec.kao@intel.com
Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 17:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment