Attention is currently required from: Raul Rangel, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62500 )
Change subject: cpu/x86/smm: Add weak SoC and mainboard init and exit methods
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I'm not opposed, but why not just add calls to the early mainboard and SOC inits if they're needed?
Oops, forgot to uncheck the resolved box.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I946619cd62a974a98c575a92943b43ea639fc329
Gerrit-Change-Number: 62500
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Mar 2022 20:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment