Attention is currently required from: Paul Menzel, Xuxin Xiong, Yang Wu.
Haikun Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82054?usp=email )
Change subject: drivers/mipi: Add support for STA_ER88576 panel
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82054/comment/abf35388_26f38b9c :
PS5, Line 9: Add STA panel STA_ER88577 serializable data to CBFS.
Please mention the datasheet name and revision, and how you wrote the initialization.
Done
https://review.coreboot.org/c/coreboot/+/82054/comment/4615bbb7_803cb0b1 :
PS5, Line 12: include
includes
Done
File src/drivers/mipi/panel-STA_ER88577.c:
https://review.coreboot.org/c/coreboot/+/82054/comment/e6f818d2_546bff1d :
PS5, Line 57: PANEL_DELAY(120),
That is quite long.
We need this delay to light up the screen normally, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82054?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7
Gerrit-Change-Number: 82054
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haikun Zhou
zhouhaikun5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Apr 2024 06:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment