Attention is currently required from: Nico Huber, Michał Żygowski, Paul Menzel, Michał Kopeć. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61682 )
Change subject: nb/amd/common: Move RAM calcualtion to common code ......................................................................
Patch Set 5:
(3 comments)
File src/northbridge/amd/common/ram_calc.c:
https://review.coreboot.org/c/coreboot/+/61682/comment/82817812_8930c9d8 PS5, Line 28: > Should this be >= ?
https://review.coreboot.org/c/coreboot/+/61682/comment/72dea7b8_cb083e26 PS5, Line 42: nit: double spaces.
https://review.coreboot.org/c/coreboot/+/61682/comment/e4c37359_bdc8e48a PS5, Line 50: *limitk += 1; /* round up last byte for northbridge resource calculation convenience */ : *limitk /= KiB; /* Normalize to KiB */ I think you need /= KiB first and then += 1.
-
Arthur Heymans (Code Review)