Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62877 )
Change subject: mb/google/skyrim: Build APCB sources into amdfw when present
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
i don't like this approach too much, since this basically hard-codes the mainboard-specific file name on soc level and for example chausie uses different file names
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7
Gerrit-Change-Number: 62877
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 15:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment