Change in coreboot[master]: mb/google/nissa: Add gpio lock pins - coreboot-gerrit

14 Apr 2022


      Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Reka Norman, Ivy Jian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63568 )
Change subject: mb/google/nissa: Add gpio lock pins
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/63568/comment/c6ee171c_b6e1bceb 
PS3, Line 245: PAD_CFG_GPI_SCI_LOCK(GPP_F17, NONE, LEVEL, INVERT, LOCK_CONFIG),
...
does EC wake via GPIO work?
EC should change? https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3544873
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63568
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib34ca287596a6958407a944d0caf53f4bcc60d9b
Gerrit-Change-Number: 63568
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 00:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment